From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
hans-christoph.rohland@sap.com, leg@google.com,
pbadari@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tmpfs: support aio
Date: Wed, 28 May 2008 17:06:38 -0700 [thread overview]
Message-ID: <1212019598.20781.11.camel@brick> (raw)
In-Reply-To: <20080528165815.f4e4982c.akpm@linux-foundation.org>
On Wed, 2008-05-28 at 16:58 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 00:13:35 +0100 (BST)
> Hugh Dickins <hugh@veritas.com> wrote:
> hm. This version:
>
> static ssize_t shmem_file_aio_read(struct kiocb *iocb,
> const struct iovec *iov, unsigned long nr_segs, loff_t pos)
> {
> struct file *filp = iocb->ki_filp;
> ssize_t retval;
> unsigned long seg;
> size_t count;
> loff_t *ppos = &iocb->ki_pos;
>
> count = 0;
> retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> if (retval)
> return retval;
> if (count == 0)
> return 0;
>
> retval = 0;
retval has to be 0 here, no need to assign it again?
Harvey
next prev parent reply other threads:[~2008-05-29 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 23:13 [PATCH] tmpfs: support aio Hugh Dickins
2008-05-28 23:58 ` Andrew Morton
2008-05-29 0:06 ` Harvey Harrison [this message]
2008-05-29 18:24 ` Hugh Dickins
2008-05-29 18:20 ` Hugh Dickins
2008-05-29 20:54 ` [PATCH] generic_file_aio_read cleanups Hugh Dickins
2008-05-29 20:57 ` [PATCH v2] tmpfs: support aio Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212019598.20781.11.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hans-christoph.rohland@sap.com \
--cc=hugh@veritas.com \
--cc=leg@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox