From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754861AbYEaRG5 (ORCPT ); Sat, 31 May 2008 13:06:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751593AbYEaRGr (ORCPT ); Sat, 31 May 2008 13:06:47 -0400 Received: from c60.cesmail.net ([216.154.195.49]:41483 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbYEaRGq (ORCPT ); Sat, 31 May 2008 13:06:46 -0400 Subject: Re: Wireless-testing's b43 panics in b43_generate_txhdr on packet transmit From: Pavel Roskin To: Stefanik =?ISO-8859-1?Q?G=E1bor?= Cc: "bcm43xx-dev@lists.berlios.de" , linux-wireless , linux-kernel@vger.kernel.org In-Reply-To: <69e28c910805310954s6c478001h837415a6a63d26f0@mail.gmail.com> References: <69e28c910805310723j2b721030x2609cc9e866abafa@mail.gmail.com> <1212252522.2766.8.camel@rd> <69e28c910805310954s6c478001h837415a6a63d26f0@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Date: Sat, 31 May 2008 13:06:44 -0400 Message-Id: <1212253604.2766.15.camel@rd> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2008-05-31 at 18:54 +0200, Stefanik Gábor wrote: > On Sat, May 31, 2008 at 6:48 PM, Pavel Roskin wrote: > > It's strange that other drivers (b43legacy, ath5k) use > > info->control.hw_key->hw_key_idx under the same conditions (see how > > use_encryption is calculated), but don't have any problems on the same > > network (but I need to recheck). > > Hmm... does ath5k use hardware crypto? No, it doesn't, at least with WEP, if I understand ath5k_set_key() correctly. > B43 does (but not with > nohwcrypt - and that appears to be a valid workaround), b43legacy > doesn't AFAIK. Although the code with use_encryption is present in b43legacy, it don't see any references to "set_key", so I guess you are right. Well, that explains something. -- Regards, Pavel Roskin