From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: [PATCH] quota: Remove use of info_any_dirty()
Date: Mon, 2 Jun 2008 19:11:07 +0200 [thread overview]
Message-ID: <12124266712838-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <12124266711334-git-send-email-jack@suse.cz>
Since there is only a single place which uses info_any_dirty() and that
is a trivial macro, just remove the use of this macro completely.
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/quota.c | 7 +++++--
include/linux/quota.h | 2 --
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/quota.c b/fs/quota.c
index db1cc9f..f0702f4 100644
--- a/fs/quota.c
+++ b/fs/quota.c
@@ -199,8 +199,11 @@ restart:
list_for_each_entry(sb, &super_blocks, s_list) {
/* This test just improves performance so it needn't be reliable... */
for (cnt = 0, dirty = 0; cnt < MAXQUOTAS; cnt++)
- if ((type == cnt || type == -1) && sb_has_quota_enabled(sb, cnt)
- && info_any_dirty(&sb_dqopt(sb)->info[cnt]))
+ if ((type == cnt || type == -1)
+ && sb_has_quota_enabled(sb, cnt)
+ && (info_dirty(&sb_dqopt(sb)->info[cnt])
+ || !list_empty(&sb_dqopt(sb)->
+ info[cnt].dqi_dirty_list)))
dirty = 1;
if (!dirty)
continue;
diff --git a/include/linux/quota.h b/include/linux/quota.h
index dcddfb2..6f1d97d 100644
--- a/include/linux/quota.h
+++ b/include/linux/quota.h
@@ -224,8 +224,6 @@ struct super_block;
extern void mark_info_dirty(struct super_block *sb, int type);
#define info_dirty(info) test_bit(DQF_INFO_DIRTY_B, &(info)->dqi_flags)
-#define info_any_dquot_dirty(info) (!list_empty(&(info)->dqi_dirty_list))
-#define info_any_dirty(info) (info_dirty(info) || info_any_dquot_dirty(info))
#define sb_dqopt(sb) (&(sb)->s_dquot)
#define sb_dqinfo(sb, type) (sb_dqopt(sb)->info+(type))
--
1.5.2.4
next prev parent reply other threads:[~2008-06-02 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 17:11 Cleanup quota header files Jan Kara
2008-06-02 17:11 ` [PATCH] quota: Rename quota functions from upper case, make bigger ones non-inline Jan Kara
2008-06-02 17:11 ` Jan Kara [this message]
2008-06-02 17:11 ` [PATCH] ext4: Add explicit include of <linux/quota.h> into ext4_jbd2.h Jan Kara
2008-06-02 17:11 ` [PATCH] ext2: Add explicit include of <linux/quota.h> into super.c Jan Kara
2008-06-02 17:11 ` [PATCH] quota: Split out quota_struct.h out of quota.h Jan Kara
2008-06-02 17:11 ` [PATCH] quota: Convert macros to inline functions Jan Kara
2008-06-04 13:56 ` [PATCH] quota: Split out quota_struct.h out of quota.h Adrian Bunk
2008-06-04 14:51 ` Jan Kara
2008-06-04 15:26 ` Adrian Bunk
2008-06-04 15:38 ` David Woodhouse
2008-06-04 17:57 ` Jan Kara
2008-06-02 17:41 ` [PATCH] quota: Remove use of info_any_dirty() Vegard Nossum
2008-06-03 9:03 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12124266712838-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox