* [PATCH 1/2] lib: export bitrev16
@ 2008-06-03 18:19 Harvey Harrison
2008-06-04 6:46 ` Marcel Holtmann
2008-06-04 15:04 ` Akinobu Mita
0 siblings, 2 replies; 3+ messages in thread
From: Harvey Harrison @ 2008-06-03 18:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, Marcel Holtmann
Bluetooth will be able to use this.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/linux/bitrev.h | 1 +
lib/bitrev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
index 05e540d..7ffe03f 100644
--- a/include/linux/bitrev.h
+++ b/include/linux/bitrev.h
@@ -10,6 +10,7 @@ static inline u8 bitrev8(u8 byte)
return byte_rev_table[byte];
}
+extern u16 bitrev16(u16 in);
extern u32 bitrev32(u32 in);
#endif /* _LINUX_BITREV_H */
diff --git a/lib/bitrev.c b/lib/bitrev.c
index 989aff7..3956203 100644
--- a/lib/bitrev.c
+++ b/lib/bitrev.c
@@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
};
EXPORT_SYMBOL_GPL(byte_rev_table);
-static __always_inline u16 bitrev16(u16 x)
+u16 bitrev16(u16 x)
{
return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
}
+EXPORT_SYMBOL(bitrev16);
/**
* bitrev32 - reverse the order of bits in a u32 value
--
1.5.6.rc0.336.ge5422
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] lib: export bitrev16
2008-06-03 18:19 [PATCH 1/2] lib: export bitrev16 Harvey Harrison
@ 2008-06-04 6:46 ` Marcel Holtmann
2008-06-04 15:04 ` Akinobu Mita
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2008-06-04 6:46 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, LKML
Hi Harvey,
> Bluetooth will be able to use this.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] lib: export bitrev16
2008-06-03 18:19 [PATCH 1/2] lib: export bitrev16 Harvey Harrison
2008-06-04 6:46 ` Marcel Holtmann
@ 2008-06-04 15:04 ` Akinobu Mita
1 sibling, 0 replies; 3+ messages in thread
From: Akinobu Mita @ 2008-06-04 15:04 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, LKML, Marcel Holtmann
> --- a/lib/bitrev.c
> +++ b/lib/bitrev.c
> @@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
> };
> EXPORT_SYMBOL_GPL(byte_rev_table);
>
> -static __always_inline u16 bitrev16(u16 x)
> +u16 bitrev16(u16 x)
> {
> return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
> }
> +EXPORT_SYMBOL(bitrev16);
How about just moving bitrev16() from lib/bitrev.c to include/linux/bitrev.h
with s/__always_inline/inline/ rather than making it export symbol?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-04 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-03 18:19 [PATCH 1/2] lib: export bitrev16 Harvey Harrison
2008-06-04 6:46 ` Marcel Holtmann
2008-06-04 15:04 ` Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox