From: Marcel Holtmann <marcel@holtmann.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] bluetooth: hci_bcsp.c small cleanups/api users
Date: Wed, 04 Jun 2008 08:53:44 +0200 [thread overview]
Message-ID: <1212562424.6339.3.camel@californication> (raw)
In-Reply-To: <1212517161.11008.60.camel@brick>
Hi Harvey,
> Use bitrev16 from lib/bitrev.c.
>
> Use the get_unaligned_be16 to get the crc from the packet, create a
> small helper function for this.
>
> Fix a shadowed variable sparse warning:
> drivers/bluetooth/hci_bcsp.c:218:26: warning: symbol 'hdr' shadows an earlier one
> drivers/bluetooth/hci_bcsp.c:187:5: originally declared here
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2008-06-04 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 18:19 [PATCH 2/2] bluetooth: hci_bcsp.c small cleanups/api users Harvey Harrison
2008-06-04 6:53 ` Marcel Holtmann [this message]
2008-06-04 13:58 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212562424.6339.3.camel@californication \
--to=marcel@holtmann.org \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox