public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Thomas Tuttle <ttuttle@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] pagemap: Make /proc/kpage{count,flags} return EINVAL (not EIO) on unaligned read.
Date: Thu, 05 Jun 2008 11:24:46 -0500	[thread overview]
Message-ID: <1212683087.3953.184.camel@calx> (raw)
In-Reply-To: <4ca0a85e0806050807v1ad0c309y75badc3fff7b796f@mail.gmail.com>


On Thu, 2008-06-05 at 11:07 -0400, Thomas Tuttle wrote:
> If a process tries to read at a position that's not a multiple of 8,
> or for a count that's not a multiple of 8, they've passed an invalid
> argument to read (for this file), so we should return EINVAL.

This patch should probably precede your 3/5.

-- 
Mathematics is the supreme nostalgia of our time.


      reply	other threads:[~2008-06-05 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05 15:07 [PATCH 4/5] pagemap: Make /proc/kpage{count,flags} return EINVAL (not EIO) on unaligned read Thomas Tuttle
2008-06-05 16:24 ` Matt Mackall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212683087.3953.184.camel@calx \
    --to=mpm@selenic.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ttuttle@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox