public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: ciaby <ciaby@autistici.org>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] 2.6.25.4-rt6: missing global_rt_runtime() in sched.c
Date: Mon, 09 Jun 2008 11:02:20 -0700	[thread overview]
Message-ID: <1213034540.16459.4.camel@localhost.localdomain> (raw)
In-Reply-To: <7688fdc041a8f848b0627dccccddcf12@localhost>


On Mon, 2008-06-09 at 09:51 +0000, ciaby wrote:
> I already sent this patch, but seems that nobody cared... the last 2
> revisions of the -rt kernel don't compile properly.
> Second patch to fix this.
> Regards
> 
> Giovanni "ciaby" Civardi
> 
> diff -uNr linux-2.6.25.4-rt6.orig/kernel/sched.c
> linux-2.6.25.4-rt6/kernel/sched.c
> --- linux-2.6.25.4-rt6.orig/kernel/sched.c      2008-06-09
> 11:35:57.000000000 +0200
> +++ linux-2.6.25.4-rt6/kernel/sched.c   2008-06-09 11:40:45.000000000 +0200
> @@ -672,6 +672,13 @@
>   */
>  #define RUNTIME_INF    ((u64)~0ULL)
>  
> +static u64 global_rt_runtime(void)
> +{
> +       if (sysctl_sched_rt_period < 0)
> +               return RUNTIME_INF;
> +       return (u64)sysctl_sched_rt_runtime * NSEC_PER_USEC;

Your patch has a couple of problems .. It's line wrapped, it's missing
proper tabbing (got stripped maybe), and no Signed-off-by: .. 

Daniel


  parent reply	other threads:[~2008-06-09 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09  9:51 [PATCH] 2.6.25.4-rt6: missing global_rt_runtime() in sched.c ciaby
2008-06-09 12:54 ` Tarkan Erimer
2008-06-09 18:02 ` Daniel Walker [this message]
2008-06-13 10:07 ` ciaby
2008-06-13 19:23   ` Daniel Walker
2008-06-23 22:43 ` Steven Rostedt
2008-06-24  1:30   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213034540.16459.4.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=ciaby@autistici.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox