From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrea Righi <righi.andrea@gmail.com>
Cc: balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
kosaki.motohiro@jp.fujitsu.com, containers@lists.osdl.org,
menage@google.com, xemul@openvz.org
Subject: Re: [RFC PATCH 3/5] mgmcg VM overcommit interface
Date: Tue, 10 Jun 2008 10:42:26 -0700 [thread overview]
Message-ID: <1213119746.13882.15.camel@nimitz> (raw)
In-Reply-To: <1213054383-18137-4-git-send-email-righi.andrea@gmail.com>
On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote:
>
> + cgroup_unlock();
> +
> + count = sprintf(page, "CommitLimit: %8lu kB\n"
> + "Committed_AS: %8lu kB\n",
> + K(allowed), K(committed));
> + ret = simple_read_from_buffer(userbuf, nbytes, ppos, page, count);
> +out:
> + free_page((unsigned long)page);
> + return ret;
> +}
I know you're trying to make this look like meminfo, but it does butcher
the sysfs rules a bit. How about breaking it out into a couple of
files?
-- Dave
next prev parent reply other threads:[~2008-06-10 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 23:33 [RFC PATCH 3/5] mgmcg VM overcommit interface Andrea Righi
2008-06-10 17:42 ` Dave Hansen [this message]
2008-06-11 10:43 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213119746.13882.15.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=righi.andrea@gmail.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox