public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Dario Faggioli <raistlin@linux.it>
Cc: Michael Trimarchi <trimarchimichael@yahoo.it>,
	mingo@elte.hu,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: NULL pointer dereference while setting sched_rt_period_us
Date: Wed, 18 Jun 2008 09:48:31 +0200	[thread overview]
Message-ID: <1213775311.16944.199.camel@twins> (raw)
In-Reply-To: <1213773519.5371.8.camel@Palanthas.Krynn>

On Wed, 2008-06-18 at 09:18 +0200, Dario Faggioli wrote:
> Hi all,

Thanks! I'll push it fwd with my other rt-group fixes

> We think the following patch solves the issue.
> 
> Hope this is of some help.
> 
> Regards,
> Dario Faggioli
> 
> Signed-off-by: Dario Faggioli <raistlin@linux.it>
> Signed-off-by: Michael Trimarchi <trimarchimichael@yahoo.it>
> ---
> diff --git a/kernel/sched.c b/kernel/sched.c
> index eaf6751..7205e25 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -8348,7 +8348,7 @@ static unsigned long to_ratio(u64 period, u64
> runtime)
>  #ifdef CONFIG_CGROUP_SCHED
>  static int __rt_schedulable(struct task_group *tg, u64 period, u64
> runtime)
>  {
> -	struct task_group *tgi, *parent = tg->parent;
> +	struct task_group *tgi, *parent = tg ? tg->parent : NULL;
>  	unsigned long total = 0;
>  
>  	if (!parent) {
> 


  reply	other threads:[~2008-06-18  7:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  7:18 NULL pointer dereference while setting sched_rt_period_us Dario Faggioli
2008-06-18  7:48 ` Peter Zijlstra [this message]
2008-06-19 10:12   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213775311.16944.199.camel@twins \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=raistlin@linux.it \
    --cc=trimarchimichael@yahoo.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox