From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761671AbYFXRUk (ORCPT ); Tue, 24 Jun 2008 13:20:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761517AbYFXRUV (ORCPT ); Tue, 24 Jun 2008 13:20:21 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:7040 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761514AbYFXRUT (ORCPT ); Tue, 24 Jun 2008 13:20:19 -0400 Subject: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3 From: Lee Schermerhorn To: Andrew Morton Cc: KOSAKI Motohiro , KAMEZAWA Hiroyuki , linux-mm , LKML , Rik van Riel In-Reply-To: <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com> References: <20080621185408.E832.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com> Content-Type: text/plain Organization: HP/OSLO Date: Tue, 24 Jun 2008 13:19:47 -0400 Message-Id: <1214327987.6563.22.camel@lts-notebook> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PATCH fix to rework of putback_lru_page locking. Against: 26-rc5-mm3 atop Kosaki Motohiro's v3 rework of Kamezawa Hiroyuki's putback_lru_page rework patch. 'lru' was not being set to 'UNEVICTABLE when page was, in fact, unevictable [really "nonreclaimable" :-)], so retry would never happen, and culled pages never counted. Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru', in the case of unevictable pages--messes up memcontroller tracking [I think]. Signed-off-by: Lee Schermerhorn mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.26-rc5-mm3/mm/vmscan.c =================================================================== --- linux-2.6.26-rc5-mm3.orig/mm/vmscan.c 2008-06-23 11:45:26.000000000 -0400 +++ linux-2.6.26-rc5-mm3/mm/vmscan.c 2008-06-24 12:45:15.000000000 -0400 @@ -514,8 +514,8 @@ redo: * Put unevictable pages directly on zone's unevictable * list. */ + lru = LRU_UNEVICTABLE; add_page_to_unevictable_list(page); - mem_cgroup_move_lists(page, LRU_UNEVICTABLE); } mem_cgroup_move_lists(page, lru);