Re: [PATCH 1/2] x86 boot: add E820_RESVD_KERN

["Huang, Ying" <ying.huang@intel.com>]

On Thu, 2008-06-26 at 00:25 -0700, Yinghai Lu wrote:
[...]
> >                if (pfn >= limit_pfn)
> > @@ -977,7 +978,7 @@ u64 __init early_reserve_e820(u64 startt
> >                return 0;
> >
> >        addr = round_down(start + size - sizet, align);
> > -       e820_update_range(addr, sizet, E820_RAM, E820_RESERVED);
> > +       e820_update_range(addr, sizet, E820_RAM, E820_RESVD_KERN);
> 
> this line is not needed.

Why? Memory reserved by early_rserved_e820 should not be saved during
hibernation? shoudl not be saved by kdump?

> >        printk(KERN_INFO "update e820 for early_reserve_e820\n");
> >        update_e820();
> >
> > @@ -1191,6 +1192,7 @@ void __init e820_reserve_resources(void)
> >        res = alloc_bootmem_low(sizeof(struct resource) * e820.nr_map);
> >        for (i = 0; i < e820.nr_map; i++) {
> >                switch (e820.map[i].type) {
> > +               case E820_RESVD_KERN:
> >                case E820_RAM:  res->name = "System RAM"; break;
> >                case E820_ACPI: res->name = "ACPI Tables"; break;
> >                case E820_NVS:  res->name = "ACPI Non-volatile Storage"; break;
> >
> > --
> 
> please  move reserve_setup_data() from head.c/head64.c to setup32/64.c
> or merged setup.c

OK.

> also need to change reserve_early in reserve_setup_data to
> e820_update_range(,,E820_RAM, E820_RESEVED_EXTRA).

Does this means reserve_early() should be replaced by
e820_update_range()?

> calling reserve_setup_data() should around early_reserve_e820_mpc_new.

I think reserve_xxx should be called before first find_e820_area() to
minimize the possibility of conflict.

> we don't need early_res_to_e820.

Best Regards,
Huang Ying