The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	andi@firstfloor.org, mingo@redhat.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86 boot: early_res_to_e820
Date: Thu, 26 Jun 2008 16:03:31 +0800	[thread overview]
Message-ID: <1214467411.11346.34.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <86802c440806260029l35b68e4fh89264e1796e7863b@mail.gmail.com>

On Thu, 2008-06-26 at 00:29 -0700, Yinghai Lu wrote:
[...]
> >
> > For example, if EFI memory map is allocated in highmem area by
> > boot-loader, it need to be reserved in kernel. But on i386, bootmem can
> > only reserve memory area below max_low_pfn. So I think this is needed.
> >
> > In general, I think it is needed to provide a reservation mechanism for
> > highmem area on i386. Because some memory area from BIOS or boot-loader
> > may in highmem area.
> 
> I mean call reserve_setup_data right after finish_e820_parsing,  and
> it could call e820_update_range directly.

e820_update_range() can only be used after finish_e820_parsing()?

parse_setup_data() should be called before parse_early_param() to let
early_param override settings in setup_data. Which is before
finish_e820_parsing(). It seems a little wired to use the data before
reserve it.

And this means find_e820_area() should not be called before
e820_update_range()?

Best Regards,
Huang Ying


  reply	other threads:[~2008-06-26  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26  6:33 [PATCH 2/2] x86 boot: early_res_to_e820 Huang, Ying
2008-06-26  7:13 ` Yinghai Lu
2008-06-26  7:27   ` Huang, Ying
2008-06-26  7:29     ` Yinghai Lu
2008-06-26  8:03       ` Huang, Ying [this message]
2008-06-26  9:43         ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214467411.11346.34.camel@caritas-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox