From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261397AbUKIKcO (ORCPT ); Tue, 9 Nov 2004 05:32:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261467AbUKIKcO (ORCPT ); Tue, 9 Nov 2004 05:32:14 -0500 Received: from mx1.redhat.com ([66.187.233.31]:5594 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261397AbUKIKcL (ORCPT ); Tue, 9 Nov 2004 05:32:11 -0500 From: David Howells In-Reply-To: <20041108143409.79bf7fd8.akpm@osdl.org> References: <20041108143409.79bf7fd8.akpm@osdl.org> <200411081432.iA8EWewv023403@warthog.cambridge.redhat.com> To: Andrew Morton Cc: torvalds@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH] Termio userspace access error handling User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Tue, 09 Nov 2004 10:31:59 +0000 Message-ID: <12145.1099996319@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > > The attached patch creates a generic set of termio userspace access > > functions with proper error handling. None of the current archs check for > > errors in this case. > > Why are they inlined? Each function is used a single time. Also they can't just be integrated into the calling functions though because some archs need to handle them differently. David