From: Peter Zijlstra <peterz@infradead.org>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: Paul Menage <menage@google.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Paul Jackson <pj@sgi.com>,
a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [RFC][PATCH] CPUSets: Move most calls to rebuild_sched_domains() to the workqueue
Date: Thu, 26 Jun 2008 21:19:05 +0200 [thread overview]
Message-ID: <1214507945.12265.7.camel@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <4863E4C8.9050705@qualcomm.com>
On Thu, 2008-06-26 at 11:49 -0700, Max Krasnyansky wrote:
> > Does that mean that you can't ever call get_online_cpus() from a
> > workqueue thread?
>
> In general it should be ok (no different from user-space task calling
> it). But there is still circular dependency because we're calling into
> domain partitioning code.
> Below is more detailed lockdep report with your patch applied on top of
> -rc8.
> Looks like this might be a good time to rethink overall locking in there.
Gautham has been working on some of this recently. Perhaps he can share
his patch-stack again.
next prev parent reply other threads:[~2008-06-26 19:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 7:56 [RFC][PATCH] CPUSets: Move most calls to rebuild_sched_domains() to the workqueue Paul Menage
2008-06-26 9:34 ` Vegard Nossum
2008-06-26 9:50 ` Paul Menage
2008-06-26 18:49 ` Max Krasnyansky
2008-06-26 19:19 ` Peter Zijlstra [this message]
2008-06-26 20:34 ` Paul Menage
2008-06-26 21:17 ` Paul Menage
2008-06-27 5:10 ` Max Krasnyansky
2008-06-27 5:51 ` Paul Menage
2008-06-27 17:31 ` Max Krasnyansky
2008-06-27 3:22 ` Gautham R Shenoy
2008-06-27 3:23 ` Gautham R Shenoy
2008-06-27 4:53 ` Max Krasnyansky
2008-06-27 16:42 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214507945.12265.7.camel@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox