From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757766AbYF3HAM (ORCPT ); Mon, 30 Jun 2008 03:00:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754639AbYF3G75 (ORCPT ); Mon, 30 Jun 2008 02:59:57 -0400 Received: from mga14.intel.com ([143.182.124.37]:47498 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbYF3G74 convert rfc822-to-8bit (ORCPT ); Mon, 30 Jun 2008 02:59:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.27,725,1204531200"; d="scan'208";a="4437632" Subject: Re: [PATCH 1/2] x86 boot: add E820_RESVD_KERN From: "Huang, Ying" To: Yinghai Lu Cc: "H. Peter Anvin" , andi@firstfloor.org, mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org In-Reply-To: <86802c440806271505n78275758re235ef6616d95b3d@mail.gmail.com> References: <1214461978.10809.6.camel@caritas-dev.intel.com> <86802c440806260025v3fc1970aq682b568cccba4b4e@mail.gmail.com> <1214466513.11346.30.camel@caritas-dev.intel.com> <86802c440806260247p19f5b850r8757c51280912ae9@mail.gmail.com> <86802c440806261922n3f13b454o5e543e28d9a34e8e@mail.gmail.com> <1214534894.10865.6.camel@caritas-dev.intel.com> <86802c440806271505n78275758re235ef6616d95b3d@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Mon, 30 Jun 2008 15:03:54 +0800 Message-Id: <1214809434.2887.8.camel@caritas-dev.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-OriginalArrivalTime: 30 Jun 2008 06:59:48.0628 (UTC) FILETIME=[E2D31D40:01C8DA7E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-06-27 at 15:05 -0700, Yinghai Lu wrote: > On Thu, Jun 26, 2008 at 7:48 PM, Huang, Ying wrote: > > On Thu, 2008-06-26 at 19:22 -0700, Yinghai Lu wrote: > >> On Thu, Jun 26, 2008 at 2:47 AM, Yinghai Lu wrote: > >> > On Thu, Jun 26, 2008 at 12:48 AM, Huang, Ying wrote: > >> >> On Thu, 2008-06-26 at 00:25 -0700, Yinghai Lu wrote: > >> >> [...] > >> >>> > if (pfn >= limit_pfn) > >> >>> > @@ -977,7 +978,7 @@ u64 __init early_reserve_e820(u64 startt > >> >>> > return 0; > >> >>> > > >> >>> > addr = round_down(start + size - sizet, align); > >> >>> > - e820_update_range(addr, sizet, E820_RAM, E820_RESERVED); > >> >>> > + e820_update_range(addr, sizet, E820_RAM, E820_RESVD_KERN); > >> >>> > >> >>> this line is not needed. > >> >> > >> >> Why? Memory reserved by early_rserved_e820 should not be saved during > >> >> hibernation? shoudl not be saved by kdump? > >> >> > > > > Can you tell me why this line is not needed? > > > > [...] > >> some like the attach patch... > >> > >> you still can merge parse_setup_data parse_e820_ext > >> also entries in parse_e820_ext is not initialized..., __copy_e820_map > >> will do nothing. > > > > OK. Because some E820 entries are available after parse_setup_data(), > > it is better to call reserve_setup_data() after calling > > parse_setup_data() if update_e820_range() is used instead of > > reserve_early(). > > please modify it and test on your platforms then submit to Ingo.. It seems that there is an issue: - If parse_setup_data() is called before reserve_setup_data(), and there is a conflict between memory area used by setup_data and other memory area, it is possible that the contents of setup_data is changed. So that system may panic before reporting memory area conflict. And it seems that memory area conflict is not checked by e820_update_range(). So maybe it is better to use reserve_early() instead of e820_update_range() for setup_data. Best Regards, Huang Ying