Re: request_firmware vs. resume (was Re: [PATCH] bnx2 - use request_firmware())

Theodore Tso
2008-07-09T21:21:36Z

On Wed, Jul 09, 2008 at 11:13:54PM +0200, Rafael J. Wysocki wrote:
> > Be careful about request_firmware. Doing it right w.r.t.
> > suspend/resume is quite tricky: you have to load it from userspace
> > before kernel starts, so that you can use it during resume...
>
> Rather, you have to cache it in memory before your ->suspend() is invoked.

Translation: so much for saving "non-swappable kernel memory".
Unless, of course we add a pre-suspend hook. (Which doesn't exist
yet, AFAICT from a quick perusal of Documentation/power/devices.txt.)

- Ted