Re: [patch 1/17] Clear the WARN() namespace

Andrew Morton
2008-07-11T19:23:41Z

On Tue, 8 Jul 2008 09:39:30 -0700 Arjan van de Ven <arjan@infradead.org> wrote:

> From: Arjan van de Ven <arjan@linux.intel.com>
>
> We want to use WARN() as a variant of WARN_ON(), however a few drivers are
> using WARN() internally. This patch renames these to WARNING() to avoid the
> namespace clash. A few cases were defining but not using the thing, for those
> cases I just deleted the definition.
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> Acked-by: Greg KH <greg@kroah.com>
> Cc: Karsten Keil <kkeil@suse.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/isdn/hisax/st5481.h | 4
> drivers/isdn/hisax/st5481_b.c | 4
> drivers/isdn/hisax/st5481_d.c | 6
> drivers/isdn/hisax/st5481_usb.c | 18 +-
> drivers/usb/gadget/at91_udc.h | 2
> drivers/usb/gadget/cdc2.c | 2
> drivers/usb/gadget/ether.c | 2
> drivers/usb/gadget/file_storage.c | 14 -
> drivers/usb/gadget/fsl_usb2_udc.c | 2
> drivers/usb/gadget/fsl_usb2_udc.h | 2
> drivers/usb/gadget/gmidi.c | 2
> drivers/usb/gadget/goku_udc.c | 2
> drivers/usb/gadget/goku_udc.h | 2
> drivers/usb/gadget/inode.c | 2
> drivers/usb/gadget/net2280.c | 2
> drivers/usb/gadget/net2280.h | 2
> drivers/usb/gadget/omap_udc.c | 6
> drivers/usb/gadget/omap_udc.h | 2
> drivers/usb/gadget/printer.c | 2
> drivers/usb/gadget/pxa25x_udc.c | 6
> drivers/usb/gadget/pxa25x_udc.h | 2
> drivers/usb/gadget/u_ether.c | 3
> drivers/usb/host/isp116x-hcd.c | 2
> drivers/usb/host/isp116x.h | 2
> drivers/usb/host/sl811-hcd.c | 2
> drivers/usb/host/sl811.h | 2
> drivers/usb/misc/usbtest.c | 4
> include/linux/usb/composite.h | 2

After fixing rejects, this appears to be identical to what I already had.

> usr/share/quilt/refresh | 304 --------------------------------------

Except for this curosity, which I rather hope wasn't supposed to be there.