Re: [patch 0/17] Series to introduce WARN()... a WARN_ON() variant that takes printk arguments

Ingo Molnar
2008-07-09T10:14:18Z

* Arjan van de Ven <arjan@infradead.org> wrote:

> Hi,
>
> This patch series introduces WARN(), which is a WARN_ON() variant that
> takes printk() like arguments. This was done after both akpm and I hit
> several cases where this would have been useful; in addition, with
> WARN(), we put the printk string inside the -----[ cut here ]-----
> section, making it more likely that users (and tools like kerneloops)
> pick up the message in addition to just the bare WARNING.
>
> The first few patches have been in -mm for a long time; the later ones
> are newer and introduce more users of WARN().

i've created a new -git based topic branch in tip/core/warn-API and
picked up your patches:

Arjan van de Ven (16):
full tree: clear the WARN() namespace
core: add a WARN() macro that acts like WARN_ON()+printk
kobject: introduce WARN() usage in the kobject code
irq: use WARN() in kernel/irq/manage.c
mm: use WARN() in mm/vmalloc.c
lockdep: use WARN() in kernel/lockdep.c
irq: use WARN() in kernel/irq/chip.c
x86: use WARN() in arch/x86/mm/ioremap.c
x86: use WARN() in arch/x86/mm/pageattr.c
x86: use WARN() in arch/x86/kernel
block: use WARN() in block/
driver core: use WARN() in drivers/base/
core libs: use WARN() in lib/
fs: use WARN() in fs/
sysfs: use WARN() in fs/sysfs
procfs: use WARN() in fs/proc/

it can be picked up via:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core/warn-API

( Note, i added a few more tree-wide namespace preparation fixes to the
first patch - a few more came in since you first prepared this patch i
guess. )

Ingo