From: ian <spyro@f2s.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Dmitry <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device
Date: Wed, 09 Jul 2008 13:13:59 +0100 [thread overview]
Message-ID: <1215605639.3295.79.camel@wirenth> (raw)
In-Reply-To: <20080709115045.GK8517@trinity.fluff.org>
On Wed, 2008-07-09 at 12:50 +0100, Ben Dooks wrote:
>
> So, the enable/disable calls might be useful, however is there any
> reason this could not be handled by the clock framework? The
> suspend/resume entries where not used, and I belive should not be in
> here.
Hi Ben,
I agree with you on wrapping the platform device, however the enable /
disable methods must stay.
Other cores need them, and they arent only there for clock support.
I've just looked at the TMIO MMC driver to refersh my memory and the
suspend / resume hooks must stay also. TMIO MMC needs to be handled
differently when suspending and when being disabled (loss of state when
disabled).
As yet, only tc6393 is 'in tree' but Im waiting for the core to settle
down before I convert my other TMIO based code (again again) to the new
core.
So, in summary -
ACK to your changes to wrap the device as an 'mfd_device'
NAK to deleting the mfd_cell power management.
next prev parent reply other threads:[~2008-07-09 12:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 10:49 [patch 0/4] mfd updates and proposed changes Ben Dooks
2008-07-09 10:49 ` [patch 1/4] MFD: Use to_platform_device instead of container_of Ben Dooks
2008-07-09 11:10 ` Dmitry
2008-07-10 14:47 ` Samuel Ortiz
2008-07-29 0:06 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 2/4] MFD: Coding style fixes Ben Dooks
2008-07-09 11:11 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-10 14:48 ` Samuel Ortiz
2008-07-09 11:46 ` ian
2008-07-29 0:07 ` Samuel Ortiz
2008-07-09 10:49 ` [patch 3/4] MFD: Remove unnecessary fields if mfd_cell structure Ben Dooks
2008-07-09 11:09 ` Dmitry
2008-07-09 11:12 ` Ben Dooks
2008-07-09 11:16 ` Dmitry
2008-07-09 11:38 ` Ben Dooks
2008-07-09 11:44 ` Dmitry
2008-07-09 10:49 ` [patch 4/4] MFD: Change mfd platform device usage to wrapper platform_device Ben Dooks
2008-07-09 11:15 ` Dmitry
2008-07-09 11:24 ` Ben Dooks
2008-07-09 11:31 ` Dmitry
2008-07-09 11:50 ` Ben Dooks
2008-07-09 11:56 ` Dmitry
2008-07-09 12:07 ` Ben Dooks
2008-07-09 12:31 ` Dmitry
2008-07-09 13:28 ` ian
2008-07-09 13:34 ` pHilipp Zabel
2008-07-09 13:37 ` ian
2008-07-11 21:37 ` Samuel Ortiz
2008-07-09 12:13 ` ian [this message]
2008-07-09 12:29 ` pHilipp Zabel
2008-07-09 11:45 ` ian
2008-07-09 11:52 ` Dmitry
2008-07-09 21:03 ` Russell King - ARM Linux
2008-07-09 21:13 ` Dmitry Baryshkov
2008-07-09 21:13 ` ian
2008-07-11 21:41 ` Samuel Ortiz
2008-07-09 20:56 ` Russell King - ARM Linux
2008-07-09 21:04 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215605639.3295.79.camel@wirenth \
--to=spyro@f2s.com \
--cc=ben-linux@fluff.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox