From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver
Date: Fri, 11 Jul 2008 11:28:07 +0100 [thread overview]
Message-ID: <1215772087.6634.7.camel@odin> (raw)
In-Reply-To: <1215716683.17490.29.camel@localhost.localdomain>
On Thu, 2008-07-10 at 21:04 +0200, Philipp Zabel wrote:
> This adds a regulator driver for the TI bq24022 Single-Chip
> Li-Ion Charger with its nCE and ISET2 pins connected to GPIOs.
snip
> +static struct platform_driver bq24022_driver = {
> + .driver = {
> + .name = "bq24022",
> + },
> + .remove = __devexit_p(bq24022_remove),
> +};
> +
> +static int __init bq24022_init()
missing void
> +{
> + platform_driver_probe(&bq24022_driver, bq24022_probe);
> +}
> +
missing return value.
> +static void __exit bq24022_exit()
missing void
> +{
> + platform_driver_unregister(&bq24022_driver);
> +}
Could you fix these and resubmit.
Thanks
Liam
next prev parent reply other threads:[~2008-07-11 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 19:04 [PATCH 1/2] regulator: TI bq24022 Li-Ion Charger driver Philipp Zabel
2008-07-11 10:28 ` Liam Girdwood [this message]
2008-07-11 15:27 ` Philipp Zabel
2008-07-11 19:16 ` Andrew Morton
2008-07-12 13:34 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215772087.6634.7.camel@odin \
--to=lg@opensource.wolfsonmicro.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox