public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Fries <david@fries.net>,
	Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Subject: [PATCH 8/30] W1: recode w1_slave_found logic
Date: Fri, 11 Jul 2008 17:51:23 +0400	[thread overview]
Message-ID: <12157843061715-git-send-email-johnpol@2ka.mipt.ru> (raw)
In-Reply-To: <12157843054074-git-send-email-johnpol@2ka.mipt.ru>

Simplified the logic in w1_slave_found by using the new
w1_attach_slave_device function to find a slave and mark it as active
or add the device if the crc checks.

Signed-off-by: David Fries <david@fries.net>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

---
 drivers/w1/w1.c |   26 ++++++--------------------
 1 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 24312e0..4bf2001 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -836,9 +836,7 @@ void w1_reconnect_slaves(struct w1_family *f, int attach)
 
 static void w1_slave_found(struct w1_master *dev, u64 rn)
 {
-	int slave_count;
 	struct w1_slave *sl;
-	struct list_head *ent;
 	struct w1_reg_num *tmp;
 	u64 rn_le = cpu_to_le64(rn);
 
@@ -846,24 +844,12 @@ static void w1_slave_found(struct w1_master *dev, u64 rn)
 
 	tmp = (struct w1_reg_num *) &rn;
 
-	slave_count = 0;
-	list_for_each(ent, &dev->slist) {
-
-		sl = list_entry(ent, struct w1_slave, w1_slave_entry);
-
-		if (sl->reg_num.family == tmp->family &&
-		    sl->reg_num.id == tmp->id &&
-		    sl->reg_num.crc == tmp->crc) {
-			set_bit(W1_SLAVE_ACTIVE, (long *)&sl->flags);
-			break;
-		}
-
-		slave_count++;
-	}
-
-	if (slave_count == dev->slave_count &&
-		rn && ((rn >> 56) & 0xff) == w1_calc_crc8((u8 *)&rn_le, 7)) {
-		w1_attach_slave_device(dev, tmp);
+	sl = w1_slave_search_device(dev, tmp);
+	if (sl) {
+		set_bit(W1_SLAVE_ACTIVE, (long *)&sl->flags);
+	} else {
+		if (rn && tmp->crc == w1_calc_crc8((u8 *)&rn_le, 7))
+			w1_attach_slave_device(dev, tmp);
 	}
 
 	atomic_dec(&dev->refcnt);
-- 
1.4.4.4


  parent reply	other threads:[~2008-07-11 13:56 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11 13:51 w1 updates Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 1/30] W1: fix deadlocks and remove w1_control_thread Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 2/30] W1: abort search early on on exit Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 3/30] W1: don't delay search start Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 4/30] W1: w1_process, block or sleep Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 5/30] W1: feature, enable hardware strong pullup Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 6/30] W1: feature, w1_therm.c use strong pullup and documentation Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 7/30] W1: be able to manually add and remove slaves Evgeniy Polyakov
2008-07-11 13:51 ` Evgeniy Polyakov [this message]
2008-07-11 13:51 ` [PATCH 9/30] W1: new module parameter search_count Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 10/30] W1: Document add, remove, search_count, and pullup Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 11/30] W1: w1_slave_read_id read bug, use device_attribute Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 12/30] W1: w1_therm fix user buffer overflow and cat Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 13/30] W1: w1_family, remove unused variable need_exit Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 14/30] W1: w1_therm consistent mutex access code cleanup Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 15/30] W1: w1_int.c use first available master number Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 16/30] W1: w1.c s/printk/dev_dbg/ Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 17/30] W1: w1_io.c reset comments and msleep Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 18/30] W1: ds1wm.c msleep for reset Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 19/30] W1: ds2490.c correct print message Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 20/30] W1: ds2490.c add support for strong pullup Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 21/30] W1: ds2490.c ds_write_bit, grouping error, disable readback Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 22/30] W1: ds2490.c disable bit read and write Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 23/30] W1: ds2490.c simplify and fix ds_touch_bit Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 24/30] W1: ds2490.c ds_dump_status rework Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 25/30] W1: ds2490.c ds_reset remove ds_wait_status Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 26/30] W1: ds2490.c reset ds2490 in init Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 27/30] W1: ds2490.c magic number work Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 28/30] W1: ds2490.c ds_write_block remove extra ds_wait_status Evgeniy Polyakov
2008-07-11 13:51 ` [PATCH 29/30] W1: Documentation/w1/masters/ds2490 update Evgeniy Polyakov
2008-07-14 20:40   ` Randy Dunlap
2008-07-15  2:16     ` David Fries
2008-07-17 21:52       ` Randy Dunlap
2008-07-15  2:17     ` David Fries
2008-07-11 13:51 ` [PATCH 30/30] W1: ds2490.c optimize ds_set_pullup Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2008-07-29  2:04 [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup David Fries
2008-07-29  2:18 ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries
2008-07-29 23:13 ` [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup Andrew Morton
2008-07-31  2:48   ` [PATCH 8/30] W1: recode w1_slave_found logic David Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12157843061715-git-send-email-johnpol@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=akpm@linux-foundation.org \
    --cc=david@fries.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox