From: Ben Nizette <bn@niasdigital.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Brownell <david-b@pacbell.net>,
Piot Skamruk <piotr.skamruk@gmail.com>,
openwrt-devel@lists.openwrt.org
Subject: Re: [PATCH] Add SPI over GPIO driver
Date: Tue, 15 Jul 2008 15:30:51 +1000 [thread overview]
Message-ID: <1216099851.4265.156.camel@moss.renham> (raw)
In-Reply-To: <200807142109.13243.mb@bu3sch.de>
On Mon, 2008-07-14 at 21:09 +0200, Michael Buesch wrote:
> This adds a driver that lets you drive an SPI bus over
> generic GPIO pins.
Right, this is where spi-gpio is, please disregard my question in the
mmc-spi-gpio thing thread, it was domestic blindness after all :-)
Looks good overall. I'm not sure that it need pretend to be
hotpluggable though (i.e. the board info can be hardwired so there's no
need for the board setup callback). I guess this is to integrate with
your "dynamically create an mmc over spi over gpio" thinggy in the other
thread. As I said there, I'd prefer that this platform device is
treated like other platform devices and any dynamicness be introduced at
in a more generic way.
What problem are you solving (or whole in board support are you
plugging) in this dynamic plugging of MMCs?
Thanks,
--Ben.
next prev parent reply other threads:[~2008-07-15 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 19:09 [PATCH] Add SPI over GPIO driver Michael Buesch
2008-07-14 20:43 ` Andrew Morton
2008-07-15 12:52 ` Michael Buesch
2008-07-15 5:30 ` Ben Nizette [this message]
2008-07-15 13:05 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216099851.4265.156.camel@moss.renham \
--to=bn@niasdigital.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=openwrt-devel@lists.openwrt.org \
--cc=piotr.skamruk@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox