From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: systemtap@sourceware.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+
Date: Thu, 17 Jul 2008 11:53:11 -0500 [thread overview]
Message-ID: <1216313591.5515.19.camel@localhost.localdomain> (raw)
In-Reply-To: <1216313476.5515.16.camel@localhost.localdomain>
On Thu, 2008-07-17 at 11:51 -0500, James Bottomley wrote:
> In kernel 2.6.26, this patch
>
> commit 15c8b6c1aaaf1c4edd67e2f02e4d8e1bd1a51c0d
> Author: Jens Axboe <jens.axboe@oracle.com>
> Date: Fri May 9 09:39:44 2008 +0200
>
> on_each_cpu(): kill unused 'retry' parameter
>
> means that runtime/time.c is now using the wrong calling conventions.
> Fix this up and surround it by kernel versioning #ifdefs.
By the way, this is a classic illustration of the fragility problem in
holding the systemtap runtime outside of the kernel. If it had been
in-kernel, all this would be fixed up and running and no-one would even
have noticed.
At least with changes in argument numbers, the compile breaks ... it
would have been a lot nastier if one of the variables simply changed
meaning ...
James
next prev parent reply other threads:[~2008-07-17 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 16:51 [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+ James Bottomley
2008-07-17 16:53 ` James Bottomley [this message]
2008-07-17 17:42 ` Stone, Joshua I
2008-07-17 23:00 ` Stone, Joshua I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216313591.5515.19.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox