Re: [PATCH] Introducing asm/syscalls.h

[Jaswinder Singh <jaswinder@infradead.org>]

Hello Ralf,

On Sun, 2008-07-20 at 11:00 +0100, Ralf Baechle wrote:
> On Sun, Jul 20, 2008 at 02:39:00PM +0530, Jaswinder Singh wrote:
> > From: Jaswinder Singh <jaswinder@infradead.org>
> > Date: Sun, 20 Jul 2008 14:39:00 +0530
> > To: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
> > 	David Woodhouse <dwmw2@infradead.org>, rth@twiddle.net,
> > 	rmk@arm.linux.org.uk, hskinnemoen@atmel.com, cooloney@kernel.org,
> > 	starvik@axis.com, dhowells@redhat.com, ysato@users.sourceforge.jp,
> > 	tony.luck@intel.com, takata@linux-m32r.org, geert@linux-m68k.org,
> > 	ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx,
> > 	schwidefsky@de.ibm.com, lethal@linux-sh.org, chris@zankel.net
> > Subject: [PATCH] Introducing asm/syscalls.h
> > Content-Type: text/plain
> > 
> > 
> > Declaring arch-dependent syscalls for all architectures
> > Beneficial for kernel and userspace
> > 
> > Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> 
> You write beneficial for userspace - but don't add <asm/syscall.h> to
> include/asm-generic/Kbuild.asm.  

diff --git a/include/asm-generic/Kbuild.asm
b/include/asm-generic/Kbuild.asm
index 7cd25b8..af24926 100644
--- a/include/asm-generic/Kbuild.asm
+++ b/include/asm-generic/Kbuild.asm
@@ -27,6 +27,7 @@ unifdef-y += socket.h
 unifdef-y += sockios.h
 unifdef-y += stat.h
 unifdef-y += statfs.h
+unifdef-y += syscalls.h
 unifdef-y += termbits.h
 unifdef-y += termios.h
 unifdef-y += types.h

Thank you,

Jaswinder Singh.