Re: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled

[Chunbo Luo <chunbo.luo@windriver.com>]

On Mon, 2008-07-21 at 13:40 +0900, Tejun Heo wrote:
> Chunbo Luo wrote:
> >> And this message has nothing to do with SCSI.  It's printed by libata
> >> proper for several drivers which don't support ATAPI.  Did the patch
> >> really kill the warning messages?  Can you please post full boot log
> >> from 2.6.26 w/o the patch?
> > 
> > If the drivers don't support ATAPI, the hotplug task cannot find linked device,
> > and it will start the hotplug task again. Which will print messages continously 
> > like this.
> > 
> > ----------
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ...
> > ------------
> > 
> > We should find a way to avoid this kind of noisy warning messages.
> > 
> > This patch cannot kill the warning messages, but it can avoid the
> > duplicate warning messages.
> 
> Hmmm... yeah, indeed.  That check is located at rather strange place.
> Can you please test the attached patch?

I tested the attached patch on mpc7448hpc2 ,it worked. It can avoid the
multiple warning messages.

Thanks!
Chunbo
> 
> Thanks.
>