From: Pekka Enberg <penberg@cs.helsinki.fi>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org,
akpm@linux-foundation.org, riel@redhat.com
Subject: Re: [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/*
Date: Mon, 21 Jul 2008 12:08:38 +0300 [thread overview]
Message-ID: <1216631318.19173.31.camel@penberg-laptop> (raw)
In-Reply-To: <87tzellqf9.fsf@devron.myhome.or.jp>
Hi,
Pekka J Enberg <penberg@cs.helsinki.fi> writes:
> > + if (s->ctor) {
> > + x += sprintf(buf + x, "ctor : ");
> > + x += sprint_symbol(buf + x, (unsigned long)s->ctor);
> > + x += sprintf(buf + x, "\n");
On Sun, 2008-07-20 at 02:44 +0900, OGAWA Hirofumi wrote:
> How about new "%pS" like following for it? If CONFIG_KALLSYMS=n, it has
> difference though...
>
> x += sprintf(buf + x, "ctor : %pS\n", (unsigned long)s->ctor);
Looks good to me. I'd prefer to wait until this patchset is merged and
do all of mm/slub.c in one go.
Pekka
prev parent reply other threads:[~2008-07-21 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 12:30 [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/* Pekka J Enberg
2008-07-19 17:44 ` OGAWA Hirofumi
2008-07-19 17:47 ` OGAWA Hirofumi
2008-07-21 9:08 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216631318.19173.31.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox