From: Harvey Harrison <harvey.harrison@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cifs: avoid mixing bool and le16
Date: Wed, 23 Jul 2008 17:24:11 -0700 [thread overview]
Message-ID: <1216859051.30386.40.camel@brick> (raw)
In-Reply-To: <524f69650807231719y33e96d02y7b04d1115620aa1d@mail.gmail.com>
On Wed, 2008-07-23 at 19:19 -0500, Steve French wrote:
> Seems like a cast to bool or an "if ...else" would be clearer than using !!
> By the way I don't see this warning - is it a newer compiler warning?
>
Sorry, sometimes I forget to say sparse warning. This is with
__CHECK_ENDIAN__ as well.
Would you prefer:
if (pSMBr->hdr.Flags2 & SMBFLG2_UNICODE)
is_unicode = true;
else
is_unicode = false;
Instead?
Harvey
next prev parent reply other threads:[~2008-07-24 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 23:52 [PATCH] cifs: avoid mixing bool and le16 Harvey Harrison
2008-07-24 0:19 ` Steve French
2008-07-24 0:24 ` Harvey Harrison [this message]
2008-07-24 0:26 ` Steve French
2008-07-25 18:25 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216859051.30386.40.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox