Re: 22bb1be4d27... breaks hal (and NM)

[Peter Zijlstra <peterz@infradead.org>]

On Thu, 2008-07-24 at 05:11 -0700, Andrew Morton wrote:
> On Thu, 24 Jul 2008 13:57:11 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Thu, 2008-07-24 at 13:38 +0200, Johannes Berg wrote:
> > > On Thu, 2008-07-24 at 11:58 +0200, Pierre Ossman wrote:
> > > > From commit 22bb1be4d27...:
> > > > 
> > > > "The /sys/class/net/*/wireless/ direcory is, as far as I know, not used
> > > > by anyone."
> > > > 
> > > > Can't have been much of an investigation as HAL uses these to determine
> > > > if a card is a wireless one. Without this option, you cannot get
> > > > wireless support in NetworkManager, stranding most laptops.
> > > 
> > > Bzzzzt. You suck. Go check again. Hint: try hal's git tree.
> 
> err,
> 
> a) don't be rude
> 
> b) what's in various git trees is unuseful for making decisions
>    about production kernel features.
> 
> otoh the patch seems reasonable.

> So if you've enabled CONFIG_WIRELESS_EXT_SYSFS (and it correctly has
> default y) then things should continue to work OK.  And the deprecation
> date of 2010 sounds reasonable.  In fact generous, for us...
> 
> So where's the problem?

Your two previous points, a and b.

That help text should really have mentioned current software, not future
software. And the tone of the reply.