From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Pierre Ossman <drzeus-list@drzeus.cx>,
"John W. Linville" <linville@tuxdriver.com>,
Jean Tourrilhes <jt@hpl.hp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC: 2.6 patch] clarify the WIRELESS_EXT_SYSFS help text
Date: Thu, 24 Jul 2008 14:54:48 +0200 [thread overview]
Message-ID: <1216904088.7257.328.camel@twins> (raw)
In-Reply-To: <20080724124225.GD32109@cs181140183.pp.htv.fi>
On Thu, 2008-07-24 at 15:42 +0300, Adrian Bunk wrote:
> On Thu, Jul 24, 2008 at 01:38:40PM +0200, Johannes Berg wrote:
> > On Thu, 2008-07-24 at 11:58 +0200, Pierre Ossman wrote:
> > > From commit 22bb1be4d27...:
> > >
> > > "The /sys/class/net/*/wireless/ direcory is, as far as I know, not used
> > > by anyone."
> > >
> > > Can't have been much of an investigation as HAL uses these to determine
> > > if a card is a wireless one. Without this option, you cannot get
> > > wireless support in NetworkManager, stranding most laptops.
> >
> > Bzzzzt. You suck. Go check again. Hint: try hal's git tree.
>
> Can everyone agree on the patch below?
>
> > johannes
>
> cu
> Adrian
>
>
> <-- snip -->
>
>
> Current Hal uses the CONFIG_WIRELESS_EXT_SYSFS files, so don't claim
> there were no known users and recommend to enable the option.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> b685f62718b947264657c298e5ee5b2149200f68
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index ab015c6..e582432 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -39,4 +39,4 @@ config WIRELESS_EXT_SYSFS
> files in /sys/class/net/*/wireless/. The same information
> is available via the ioctls as well.
>
> - Say Y if you have programs using it (we don't know of any).
> + If unsure, say Y.
Maybe also add:
"HAL <= 0.5.11 depends on this feature."
Where I hope I got the version number right :-)
next prev parent reply other threads:[~2008-07-24 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 9:58 22bb1be4d27... breaks hal (and NM) Pierre Ossman
2008-07-24 11:38 ` Johannes Berg
2008-07-24 11:57 ` Peter Zijlstra
2008-07-24 12:08 ` Johannes Berg
2008-07-24 12:11 ` Andrew Morton
2008-07-24 12:22 ` Peter Zijlstra
2008-07-24 12:33 ` Alistair John Strachan
2008-07-24 12:42 ` [RFC: 2.6 patch] clarify the WIRELESS_EXT_SYSFS help text Adrian Bunk
2008-07-24 12:54 ` Peter Zijlstra [this message]
2008-07-24 20:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216904088.7257.328.camel@twins \
--to=peterz@infradead.org \
--cc=bunk@kernel.org \
--cc=drzeus-list@drzeus.cx \
--cc=johannes@sipsolutions.net \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox