public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Nizette <bn@niasdigital.com>
To: righi.andrea@gmail.com
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
	kernel <kernel@avr32linux.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [REGRESSION] PAGE_ALIGN(): correctly handle ... breaks AVR32 build
Date: Fri, 25 Jul 2008 10:41:57 +1000	[thread overview]
Message-ID: <1216946517.4004.306.camel@moss.renham> (raw)


As of

commit 27ac792ca0b0a1e7e65f20342260650516c95864
Author: Andrea Righi <righi.andrea@gmail.com>
Date:   Wed Jul 23 21:28:13 2008 -0700

    PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures

We no longer have PAGE_ALIGN in asm-avr32/page.h so the AVR32 build dies
quite quickly:

  CC      init/main.o
In file included from include/linux/utsname.h:35,
                 from init/main.c:20:
include/linux/sched.h: In function 'arch_pick_mmap_layout':
include/linux/sched.h:2149: error: implicit declaration of function 'PAGE_ALIGN'
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2

This looks a relatively simple fix, just include linux/mm.h from
asm-avr32/processor.h from where sched.h gets the dodgy macro.
Unfortunately this, and every other placement of an #include
<linux/mm.h> I've tried, ends up in Massive Include Armageddon as per
[1].

Ideas?

Thanks,
	--Ben.

[1] http://niasdigital.com/bnizette/logs/MIA-25-7-8.log


             reply	other threads:[~2008-07-25  0:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25  0:41 Ben Nizette [this message]
2008-07-25 10:28 ` [PATCH] Uninline arch_pick_mmap_layout Haavard Skinnemoen
2008-07-25 10:39   ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216946517.4004.306.camel@moss.renham \
    --to=bn@niasdigital.com \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=kernel@avr32linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=righi.andrea@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox