public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Fw: asm-x86/byteorder.h, CONFIG_X86_BSWAP leaks to userland
Date: Sat, 26 Jul 2008 09:40:46 -0700	[thread overview]
Message-ID: <1217090446.5971.57.camel@brick> (raw)
In-Reply-To: <20080726013931.bcc4682d.akpm@linux-foundation.org>

On Sat, 2008-07-26 at 01:39 -0700, Andrew Morton wrote:
> 
> Begin forwarded message:
> 
> Date: Mon, 21 Jul 2008 15:18:46 +0200
> From: Olaf Hering <olaf@aepfle.de>
> To: linux-kernel@vger.kernel.org
> Subject: asm-x86/byteorder.h, CONFIG_X86_BSWAP leaks to userland
> What is the purpose of CONFIG_X86_BSWAP in asm-x86/byteorder.h?
> 
> An undefined CONFIG_foo defaults to 0 (I think), so bswap is never used.
> Is this done on purpose, or can the CONFIG_ foo be moved inside
> __KERNEL__ somehow?

I believe it's there to prevent the bswap instruction from being used on
early x86_32 models (i386/i486).  As this will be 0 in userspace it is
effectively never using the bswap instruction for these routines.

I'm not sure if it's time yet to make the bswap ones be exported, as they
would no longer be usable for those early machines.  X86 guys CC:d.

Harvey


       reply	other threads:[~2008-07-26 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080726013931.bcc4682d.akpm@linux-foundation.org>
2008-07-26 16:40 ` Harvey Harrison [this message]
2008-07-26 16:48   ` Fw: asm-x86/byteorder.h, CONFIG_X86_BSWAP leaks to userland H. Peter Anvin
2008-07-26 16:59     ` Arjan van de Ven
2008-07-26 18:18       ` H. Peter Anvin
2008-07-26 17:00     ` Fw: " Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217090446.5971.57.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox