public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, stephen@blacksapphire.com,
	benm@symmetric.co.nz, jkosina@suse.cz
Subject: Re: warning in scheduler
Date: Tue, 29 Jul 2008 07:19:16 +1000	[thread overview]
Message-ID: <1217279956.11188.221.camel@pasglop> (raw)
In-Reply-To: <20080728183911.GC16059@parisc-linux.org>

On Mon, 2008-07-28 at 12:39 -0600, Matthew Wilcox wrote:
> On Mon, Jul 28, 2008 at 08:40:22PM +1000, Benjamin Herrenschmidt wrote:
> > I tend to agree. I might look into doing it for powerpc around rc3 or
> > so, when things have settled a bit.
> 
> It'd be nice if allmodconfig even compiled:
> 
> drivers/char/pcmcia/ipwireless/hardware.c:571: error: invalid use of undefined type 'struct ipw_network'
> 
> Not to mention the qla_attr patch:
> 
> +#include <linux/delay.h>
> 
> There's probably others, I just haven't got far enough in the
> compilation process yet.

Yup, it's been a pretty bad merge window (at least it's my impression as
my first one as maintainer), mostly fixing compile bugs all the time.

> But I am seeing lots of warnings _without_ the patch applied:
> 
> fs/omfs/inode.c: In function 'omfs_fill_super':
> fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
> unsigned int', but argument 2 has type 'u64'
> fs/proc/base.c: In function 'do_io_accounting':
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 3 has type 'u64'
> fs/ubifs/dir.c: In function 'ubifs_readdir':
> fs/ubifs/dir.c:437: warning: format '%llu' expects type 'long long
> unsigned int', but argument 5 has type '__le64'
> 
> (other warnings snipped for brevity).

I have a handful on powerpc too.

BTW. I'm looking at adding a %pR to print a struct resource (or maybe
a %pr for a resource_size_t and %pR for the whole resource). That would
help with the whole business of the thing being either 32 or 64 bits.

Ben.



      reply	other threads:[~2008-07-28 21:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1217214947.11188.156.camel@pasglop>
     [not found] ` <1217238791.6331.15.camel@twins>
     [not found]   ` <1217239403.11188.189.camel@pasglop>
     [not found]     ` <20080728100752.GA4717@elte.hu>
     [not found]       ` <1217241622.11188.191.camel@pasglop>
2008-07-28 18:39         ` warning in scheduler Matthew Wilcox
2008-07-28 21:19           ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217279956.11188.221.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=benm@symmetric.co.nz \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=stephen@blacksapphire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox