Re: [PATCH 1/5] docsrc: build Documentation/ sources

Boris Petkov
2008-07-30T12:22:36Z

On Wed, Jul 30, 2008 at 1:21 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
>> >
>> > With the current approach we have much better build coverage.
>> > All "allyesconfig" and "allmodconfig" builds will do the test
>> > builds which is a good think.
>> > If we introduce "make docsrc" then almost only Randy will do the
>> > test builds and report the breakage - which is not good.
>>
>> Well, i don't see anymore people than Randy doing
>>
>> CONFIG_BUILD_DOCSRC=1 make ...
>
> One such example is:
> http://kisskb.ellerman.id.au/linux-next
>
> Here the all*config will do the build test of the
> documentation and Stephen will tell if it breaks.
>
>> either so only the other option remains, which means CONFIG_BUILD_DOCSRC
>> should be "default y" for more coverage...
> No - we do not want to set config options to "default y" unless
> there are _very_ good reasons to do so.

Sorry, I had to think about it a bit to realize what you were implying - the
all(yes|mod)config targets _will_ turn on the CONFIG_BUILD_DOCSRC option
so no need for the 'default y' setting, which seems pretty silly for
that case anyway.

--
Regards/Gruß,
Boris