From: Randy Dunlap <rdunlap@xenotime.net>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Sam Ravnborg <sam@ravnborg.org>,
davem@davemloft.net
Subject: [PATCH 3/5] docsrc: fix ifenslave type
Date: Tue, 29 Jul 2008 13:05:15 -0700 [thread overview]
Message-ID: <12173619152734@xenotime.net> (raw)
In-Reply-To: <12173619152424@xenotime.net>
From: Randy Dunlap <randy.dunlap@oracle.com>
Documentation/networking/ifenslave.c:1084: warning: pointer targets in assignment differ in signedness
>From include/linux/socket.h:
* 1003.1g requires sa_family_t and that sa_data is char.
and from SUSv3:
(http://www.opengroup.org/onlinepubs/009695399/basedefs/sys/socket.h.html)
The <sys/socket.h> header shall define the sockaddr structure that includes at least the following members:
sa_family_t sa_family Address family.
char sa_data[] Socket address (variable-length data).
<end SUSv3>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
Documentation/networking/ifenslave.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20080729.orig/Documentation/networking/ifenslave.c
+++ linux-next-20080729/Documentation/networking/ifenslave.c
@@ -1081,7 +1081,7 @@ static int set_if_addr(char *master_ifna
}
- ipaddr = ifr.ifr_addr.sa_data;
+ ipaddr = (unsigned char *)ifr.ifr_addr.sa_data;
v_print("Interface '%s': set IP %s to %d.%d.%d.%d\n",
slave_ifname, ifra[i].desc,
ipaddr[0], ipaddr[1], ipaddr[2], ipaddr[3]);
--
next prev parent reply other threads:[~2008-07-29 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 20:05 [PATCH 1/5] docsrc: build Documentation/ sources Randy Dunlap
2008-07-29 20:05 ` [PATCH 5/5] docsrc: fix getdelays printk formats Randy Dunlap
2008-07-29 20:05 ` [PATCH 2/5] docsrc: fix procfs example Randy Dunlap
2008-07-29 20:05 ` [PATCH 4/5] docsrc: fix crc32hash type Randy Dunlap
2008-07-30 6:47 ` Dominik Brodowski
2008-07-30 7:18 ` Andrew Morton
2008-07-30 8:40 ` Sam Ravnborg
2008-07-29 20:05 ` Randy Dunlap [this message]
2008-07-29 20:27 ` [PATCH 1/5] docsrc: build Documentation/ sources Borislav Petkov
2008-07-29 21:10 ` Randy Dunlap
2008-07-30 8:44 ` Sam Ravnborg
2008-07-30 8:55 ` Boris Petkov
2008-07-30 11:21 ` Sam Ravnborg
2008-07-30 12:22 ` Boris Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12173619152734@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox