From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
hpa <hpa@zytor.com>, Eric Biederman <ebiederm@xmission.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH 08/16] serial: change remove NR_IRQS in 8250.c v2
Date: Fri, 1 Aug 2008 02:37:36 -0700 [thread overview]
Message-ID: <1217583464-28494-9-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1217583464-28494-8-git-send-email-yhlu.kernel@gmail.com>
replace
[PATCH] serial: change irq_lists to use dyn_array
use small array with index to handle irq locking for serial port
hope 32 slot is enough
v2: according to Eric, move irq_no into irq_info, and not clean irq_no
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
drivers/serial/8250.c | 45 +++++++++++++++++++++++++++++++++++++++++----
1 file changed, 41 insertions(+), 4 deletions(-)
Index: linux-2.6/drivers/serial/8250.c
===================================================================
--- linux-2.6.orig/drivers/serial/8250.c
+++ linux-2.6/drivers/serial/8250.c
@@ -147,9 +147,39 @@ struct uart_8250_port {
struct irq_info {
spinlock_t lock;
struct list_head *head;
+ int irq_no;
};
-static struct irq_info irq_lists[NR_IRQS];
+#define NR_IRQ_INFO 32
+
+static struct irq_info irq_lists[NR_IRQ_INFO] = {
+ [0 ... NR_IRQ_INFO-1] = {
+ .irq_no = -1,
+ }
+};
+
+static struct irq_info *get_irq_info(int irq, int with_free)
+{
+ int i, first_free = -1;
+
+ for (i = 0; i < NR_IRQ_INFO; i++) {
+ if (irq_lists[i].irq_no == irq)
+ return &irq_lists[i];
+ if (irq_lists[i].irq_no == -1 && first_free == -1)
+ first_free = i;
+ }
+ if (!with_free)
+ return NULL;
+
+ if (first_free != -1) {
+ irq_lists[first_free].irq_no = irq;
+ return &irq_lists[first_free];
+ }
+
+ WARN_ON("NR_IRQ_INFO too small");
+
+ return NULL;
+}
/*
* Here we define the default xmit fifo size used for each type of UART.
@@ -1541,9 +1571,12 @@ static void serial_do_unlink(struct irq_
static int serial_link_irq_chain(struct uart_8250_port *up)
{
- struct irq_info *i = irq_lists + up->port.irq;
+ struct irq_info *i = get_irq_info(up->port.irq, 1);
int ret, irq_flags = up->port.flags & UPF_SHARE_IRQ ? IRQF_SHARED : 0;
+ if (!i)
+ return -1;
+
spin_lock_irq(&i->lock);
if (i->head) {
@@ -1567,7 +1600,11 @@ static int serial_link_irq_chain(struct
static void serial_unlink_irq_chain(struct uart_8250_port *up)
{
- struct irq_info *i = irq_lists + up->port.irq;
+ int irq_no = up->port.irq;
+ struct irq_info *i = get_irq_info(irq_no, 0);
+
+ if (!i)
+ return;
BUG_ON(i->head == NULL);
@@ -2951,7 +2988,7 @@ static int __init serial8250_init(void)
"%d ports, IRQ sharing %sabled\n", nr_uarts,
share_irqs ? "en" : "dis");
- for (i = 0; i < nr_irqs; i++)
+ for (i = 0; i < NR_IRQ_INFO; i++)
spin_lock_init(&irq_lists[i].lock);
ret = uart_register_driver(&serial8250_reg);
next prev parent reply other threads:[~2008-08-01 9:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 9:37 [PATCH 00/16] dyn_array and nr_irqs support v2 Yinghai Lu
2008-08-01 9:37 ` [PATCH 01/16] x86: 64bit support more than 256 irq Yinghai Lu
2008-08-01 9:37 ` [PATCH 02/16] x86: introduce nr_irqs for 64bit v3 Yinghai Lu
2008-08-01 9:37 ` [PATCH 03/16] add dyn_array support Yinghai Lu
2008-08-01 9:37 ` [PATCH 04/16] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 05/16] make irq2_iommu " Yinghai Lu
2008-08-01 9:37 ` [PATCH 06/16] make irq_desc " Yinghai Lu
2008-08-01 9:37 ` [PATCH 07/16] x86: make 64bit support dyn_array Yinghai Lu
2008-08-01 9:37 ` Yinghai Lu [this message]
2008-08-01 9:37 ` [PATCH 09/16] add per_cpu_dyn_array support Yinghai Lu
2008-08-01 9:37 ` [PATCH 10/16] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 11/16] x86 remove irq_vectors_limit.h Yinghai Lu
2008-08-01 9:37 ` [PATCH 12/16] x86: make 32bit use dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 13/16] add per_cpu_dyn_array for arch percpu support Yinghai Lu
2008-08-01 9:37 ` [PATCH 14/16] x86: get mp_irqs from madt Yinghai Lu
2008-08-01 9:37 ` [PATCH 15/16] x86: make 32bit more like with io_apic/dyn_array to 64 bit Yinghai Lu
2008-08-01 9:37 ` [PATCH 16/16] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-01 20:46 ` [PATCH 00/16] dyn_array and nr_irqs support v2 Eric W. Biederman
2008-08-01 21:30 ` Yinghai Lu
2008-08-01 21:57 ` Yinghai Lu
2008-08-01 22:45 ` Eric W. Biederman
2008-08-01 22:10 ` Yinghai Lu
2008-08-01 22:38 ` Eric W. Biederman
2008-08-02 1:09 ` Yinghai Lu
2008-08-02 1:36 ` H. Peter Anvin
2008-08-02 1:41 ` Eric W. Biederman
2008-08-02 2:01 ` Yinghai Lu
2008-08-02 2:03 ` H. Peter Anvin
2008-08-02 2:39 ` Eric W. Biederman
2008-08-02 3:28 ` H. Peter Anvin
2008-08-02 4:42 ` Eric W. Biederman
2008-08-02 15:41 ` H. Peter Anvin
2008-08-02 20:20 ` Eric W. Biederman
2008-08-04 12:57 ` Mike Travis
2008-08-05 2:38 ` H. Peter Anvin
2008-08-05 3:40 ` Eric W. Biederman
2008-08-05 3:48 ` H. Peter Anvin
2008-08-01 21:47 ` Mike Travis
2008-08-02 2:58 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217583464-28494-9-git-send-email-yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox