public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Mike Travis <travis@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2
Date: Sat,  2 Aug 2008 19:59:21 -0700	[thread overview]
Message-ID: <1217732365-16595-22-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1217732365-16595-21-git-send-email-yhlu.kernel@gmail.com>

use small array with index to handle irq locking for serial port
hope 32 slot is enough

v2: according to Eric, move irq_no into irq_info, and not clean irq_no

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
 drivers/serial/8250.c |   45 +++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 3920324..595b956 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -147,9 +147,39 @@ struct uart_8250_port {
 struct irq_info {
 	spinlock_t		lock;
 	struct list_head	*head;
+	int irq_no;
 };
 
-static struct irq_info irq_lists[NR_IRQS];
+#define NR_IRQ_INFO	32
+
+static struct irq_info irq_lists[NR_IRQ_INFO] = {
+	[0 ... NR_IRQ_INFO-1] = {
+		.irq_no = -1,
+	}
+};
+
+static struct irq_info *get_irq_info(int irq, int with_free)
+{
+	int i, first_free = -1;
+
+	for (i = 0; i < NR_IRQ_INFO; i++) {
+		if (irq_lists[i].irq_no == irq)
+			return &irq_lists[i];
+		if (irq_lists[i].irq_no == -1 && first_free == -1)
+			first_free = i;
+	}
+	if (!with_free)
+		return NULL;
+
+	if (first_free != -1) {
+		irq_lists[first_free].irq_no = irq;
+		return &irq_lists[first_free];
+	}
+
+	WARN_ON("NR_IRQ_INFO too small");
+
+	return NULL;
+}
 
 /*
  * Here we define the default xmit fifo size used for each type of UART.
@@ -1554,9 +1584,12 @@ static void serial_do_unlink(struct irq_info *i, struct uart_8250_port *up)
 
 static int serial_link_irq_chain(struct uart_8250_port *up)
 {
-	struct irq_info *i = irq_lists + up->port.irq;
+	struct irq_info *i = get_irq_info(up->port.irq, 1);
 	int ret, irq_flags = up->port.flags & UPF_SHARE_IRQ ? IRQF_SHARED : 0;
 
+	if (!i)
+		return -1;
+
 	spin_lock_irq(&i->lock);
 
 	if (i->head) {
@@ -1580,7 +1613,11 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
 
 static void serial_unlink_irq_chain(struct uart_8250_port *up)
 {
-	struct irq_info *i = irq_lists + up->port.irq;
+	int irq_no = up->port.irq;
+	struct irq_info *i = get_irq_info(irq_no, 0);
+
+	if (!i)
+		return;
 
 	BUG_ON(i->head == NULL);
 
@@ -2964,7 +3001,7 @@ static int __init serial8250_init(void)
 		"%d ports, IRQ sharing %sabled\n", nr_uarts,
 		share_irqs ? "en" : "dis");
 
-	for (i = 0; i < nr_irqs; i++)
+	for (i = 0; i < NR_IRQ_INFO; i++)
 		spin_lock_init(&irq_lists[i].lock);
 
 	ret = uart_register_driver(&serial8250_reg);
-- 
1.5.4.5


  reply	other threads:[~2008-08-03  3:07 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03  2:59 [PATCH 00/25] dyn_array and nr_irqs support v3 Yinghai Lu
2008-08-03  2:59 ` [PATCH 01/25] x86: 64bit support more than 256 irq v2 Yinghai Lu
2008-08-03  2:59   ` [PATCH 02/25] x86: remove irq_vectors_limits Yinghai Lu
2008-08-03  2:59     ` [PATCH 03/25] add dyn_array support Yinghai Lu
2008-08-03  2:59       ` [PATCH 04/25] add per_cpu_dyn_array support Yinghai Lu
2008-08-03  2:59         ` [PATCH 05/25] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-03  2:59           ` [PATCH 06/25] x86: enable dyn_array support Yinghai Lu
2008-08-03  2:59             ` [PATCH 07/25] introduce nr_irqs Yinghai Lu
2008-08-03  2:59               ` [PATCH 08/25] x86: using nr_irqs Yinghai Lu
2008-08-03  2:59                 ` [PATCH 09/25] drivers/char to use nr_irqs Yinghai Lu
2008-08-03  2:59                   ` [PATCH 10/25] drivers/net " Yinghai Lu
2008-08-03  2:59                     ` [PATCH 11/25] drivers intr remapping " Yinghai Lu
2008-08-03  2:59                       ` [PATCH 12/25] drivers/pcmcia " Yinghai Lu
2008-08-03  2:59                         ` [PATCH 13/25] drivers/rtc " Yinghai Lu
2008-08-03  2:59                           ` [PATCH 14/25] drivers/scsi " Yinghai Lu
2008-08-03  2:59                             ` [PATCH 15/25] drivers/serial " Yinghai Lu
2008-08-03  2:59                               ` [PATCH 16/25] drivers proc " Yinghai Lu
2008-08-03  2:59                                 ` [PATCH 17/25] drivers xen events " Yinghai Lu
2008-08-03  2:59                                   ` [PATCH 18/25] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-03  2:59                                     ` [PATCH 19/25] make irq2_iommu " Yinghai Lu
2008-08-03  2:59                                       ` [PATCH 20/25] make irq_desc " Yinghai Lu
2008-08-03  2:59                                         ` Yinghai Lu [this message]
2008-08-03  2:59                                           ` [PATCH 22/25] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-03  2:59                                             ` [PATCH 23/25] x86: use dyn_array in io_apic_xx.c Yinghai Lu
2008-08-03  2:59                                               ` [PATCH 24/25] x86: get mp_irqs from madt Yinghai Lu
2008-08-03  2:59                                                 ` [PATCH 25/25] x86: remove nr_irq_vectors Yinghai Lu
2008-08-03 13:03                                           ` [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Alan Cox
2008-08-03 15:14                                           ` Alan Cox
2008-08-03 19:57                                             ` Eric W. Biederman
2008-08-04 14:17                                               ` Alan Cox
2008-08-04 18:13                                                 ` Yinghai Lu
2008-08-04 18:51                                                 ` Eric W. Biederman
2008-08-06 13:09                                                   ` [PATCH] serial: Remove NR_IRQS usage Alan Cox
2008-08-06 16:10                                                     ` Eric W. Biederman
2008-08-03 13:02                               ` [PATCH 15/25] drivers/serial to use nr_irqs Alan Cox
2008-08-03 17:43                                 ` Yinghai Lu
2008-08-03  4:16           ` [PATCH 05/25] x86: alloc dyn_array all alltogether Johannes Weiner
2008-08-03  4:03       ` [PATCH 03/25] add dyn_array support Johannes Weiner
2008-08-03  4:21         ` Yinghai Lu
2008-08-03  4:55           ` Johannes Weiner
2008-08-03  5:04             ` Yinghai Lu
2008-08-03  5:31               ` Johannes Weiner
2008-08-03  5:39                 ` Yinghai Lu
2008-08-03  5:40                   ` Yinghai Lu
2008-08-03  5:47                   ` Johannes Weiner
2008-08-03  5:48                     ` Yinghai Lu
2008-08-03  5:51 ` [PATCH 00/25] dyn_array and nr_irqs support v3 Eric W. Biederman
2008-08-03  6:04   ` Yinghai Lu
2008-08-03  6:39     ` Eric W. Biederman
2008-08-03  8:25       ` Yinghai Lu
2008-08-03  9:15         ` Eric W. Biederman
2008-08-03 17:54           ` Yinghai Lu
2008-08-03 19:20             ` Yinghai Lu
2008-08-04  1:59               ` Yinghai Lu
2008-08-04 14:31       ` Mike Travis
2008-08-05 23:01 ` H. Peter Anvin
2008-08-05 23:15   ` Yinghai Lu
2008-08-05 23:26     ` H. Peter Anvin
2008-08-05 23:53       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217732365-16595-22-git-send-email-yhlu.kernel@gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox