From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH 23/25] x86: use dyn_array in io_apic_xx.c
Date: Sat, 2 Aug 2008 19:59:23 -0700 [thread overview]
Message-ID: <1217732365-16595-24-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1217732365-16595-23-git-send-email-yhlu.kernel@gmail.com>
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
arch/x86/kernel/io_apic_32.c | 54 +++++++++++++++++++++++++++++++++--------
arch/x86/kernel/io_apic_64.c | 28 ++++++++++++++++-----
arch/x86/kernel/setup.c | 6 ++++
3 files changed, 70 insertions(+), 18 deletions(-)
diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
index d5953ff..a0ce64c 100644
--- a/arch/x86/kernel/io_apic_32.c
+++ b/arch/x86/kernel/io_apic_32.c
@@ -70,7 +70,7 @@ int timer_through_8259 __initdata;
*/
int sis_apic_bug = -1;
-int first_free_entry = NR_IRQS;
+int first_free_entry;
/*
* # of IRQ routing registers
*/
@@ -98,10 +98,7 @@ static int disable_timer_pin_1 __initdata;
* Rough estimation of how many shared IRQs there are, can
* be changed anytime.
*/
-#define MAX_PLUS_SHARED_IRQS NR_IRQS
-#define PIN_MAP_SIZE (MAX_PLUS_SHARED_IRQS + NR_IRQS)
-
-int pin_map_size = PIN_MAP_SIZE;
+int pin_map_size;
/*
* This is performance-critical, we want to do it O(1)
@@ -112,7 +109,9 @@ int pin_map_size = PIN_MAP_SIZE;
static struct irq_pin_list {
int apic, pin, next;
-} irq_2_pin[PIN_MAP_SIZE];
+} *irq_2_pin;
+
+DEFINE_DYN_ARRAY(irq_2_pin, sizeof(struct irq_pin_list), pin_map_size, 16, NULL);
struct io_apic {
unsigned int index;
@@ -403,9 +402,28 @@ static struct irq_cpu_info {
#define CPU_TO_PACKAGEINDEX(i) (first_cpu(per_cpu(cpu_sibling_map, i)))
-static cpumask_t balance_irq_affinity[NR_IRQS] = {
- [0 ... NR_IRQS-1] = CPU_MASK_ALL
-};
+static cpumask_t balance_irq_affinity_init __initdata = CPU_MASK_ALL;
+
+static cpumask_t *balance_irq_affinity;
+
+
+static void __init irq_affinity_init_work(void *data)
+{
+ struct dyn_array *da = data;
+
+ int i;
+ struct balance_irq_affinity *affinity;
+
+ affinity = *da->name;
+
+ for (i = 0; i < *da->nr; i++)
+ memcpy(&affinity[i], &balance_irq_affinity_init,
+ sizeof(struct balance_irq_affinity));
+
+}
+
+DEFINE_DYN_ARRAY(balance_irq_affinity, sizeof(struct balance_irq_affinity), nr_irqs, PAGE_SIZE, irq_affinity_init_work);
+
void set_balance_irq_affinity(unsigned int irq, cpumask_t mask)
{
@@ -1170,14 +1188,28 @@ static inline int IO_APIC_irq_trigger(int irq)
}
/* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
-static u8 irq_vector[NR_IRQ_VECTORS] __read_mostly = { FIRST_DEVICE_VECTOR , 0 };
+static u8 irq_vector_init_first __initdata = FIRST_DEVICE_VECTOR;
+static u8 *irq_vector;
+
+static void __init irq_vector_init_work(void *data)
+{
+ struct dyn_array *da = data;
+
+ u8 *irq_vec;
+
+ irq_vec = *da->name;
+
+ irq_vec[0] = irq_vector_init_first;
+}
+
+DEFINE_DYN_ARRAY(irq_vector, sizeof(u8), nr_irqs, PAGE_SIZE, irq_vector_init_work);
static int __assign_irq_vector(int irq)
{
static int current_vector = FIRST_DEVICE_VECTOR, current_offset;
int vector, offset;
- BUG_ON((unsigned)irq >= NR_IRQ_VECTORS);
+ BUG_ON((unsigned)irq >= nr_irqs);
if (irq_vector[irq] > 0)
return irq_vector[irq];
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c
index 456f2e7..9bcb6c2 100644
--- a/arch/x86/kernel/io_apic_64.c
+++ b/arch/x86/kernel/io_apic_64.c
@@ -66,7 +66,7 @@ struct irq_cfg {
};
/* irq_cfg is indexed by the sum of all RTEs in all I/O APICs. */
-static struct irq_cfg irq_cfg[NR_IRQS] __read_mostly = {
+static struct irq_cfg irq_cfg_legacy[] __initdata = {
[0] = { .domain = CPU_MASK_ALL, .vector = IRQ0_VECTOR, },
[1] = { .domain = CPU_MASK_ALL, .vector = IRQ1_VECTOR, },
[2] = { .domain = CPU_MASK_ALL, .vector = IRQ2_VECTOR, },
@@ -85,6 +85,17 @@ static struct irq_cfg irq_cfg[NR_IRQS] __read_mostly = {
[15] = { .domain = CPU_MASK_ALL, .vector = IRQ15_VECTOR, },
};
+static struct irq_cfg *irq_cfg;
+
+static void __init init_work(void *data)
+{
+ struct dyn_array *da = data;
+
+ memcpy(*da->name, irq_cfg_legacy, sizeof(irq_cfg_legacy));
+}
+
+DEFINE_DYN_ARRAY(irq_cfg, sizeof(struct irq_cfg), nr_irqs, PAGE_SIZE, init_work);
+
static int assign_irq_vector(int irq, cpumask_t mask);
int first_system_vector = 0xfe;
@@ -129,10 +140,9 @@ DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES);
* Rough estimation of how many shared IRQs there are, can
* be changed anytime.
*/
-#define MAX_PLUS_SHARED_IRQS NR_IRQS
-#define PIN_MAP_SIZE (MAX_PLUS_SHARED_IRQS + NR_IRQS)
-int pin_map_size = PIN_MAP_SIZE;
+int pin_map_size;
+
/*
* This is performance-critical, we want to do it O(1)
*
@@ -141,8 +151,12 @@ int pin_map_size = PIN_MAP_SIZE;
*/
static struct irq_pin_list {
- short apic, pin, next;
-} irq_2_pin[PIN_MAP_SIZE];
+ short apic, pin;
+ int next;
+} *irq_2_pin;
+
+DEFINE_DYN_ARRAY(irq_2_pin, sizeof(struct irq_pin_list), pin_map_size, sizeof(struct irq_pin_list), NULL);
+
struct io_apic {
unsigned int index;
@@ -359,7 +373,7 @@ static void set_ioapic_affinity_irq(unsigned int irq, cpumask_t mask)
* shared ISA-space IRQs, so we have to support them. We are super
* fast in the common case, and fast for shared ISA-space IRQs.
*/
-int first_free_entry = NR_IRQS;
+int first_free_entry;
static void add_pin_to_irq(unsigned int irq, int apic, int pin)
{
struct irq_pin_list *entry = irq_2_pin + irq;
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 60e8de1..39c5106 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -856,9 +856,15 @@ void __init setup_arch(char **cmdline_p)
#endif
prefill_possible_map();
+
#ifdef CONFIG_X86_64
+ /* need to wait for nr_cpu_ids settle down */
+ if (nr_irqs == NR_IRQS)
+ nr_irqs = 32 * nr_cpu_ids + 224;
init_cpu_to_node();
#endif
+ pin_map_size = nr_irqs * 2;
+ first_free_entry = nr_irqs;
init_apic_mappings();
ioapic_init_mappings();
--
1.5.4.5
next prev parent reply other threads:[~2008-08-03 3:08 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 2:59 [PATCH 00/25] dyn_array and nr_irqs support v3 Yinghai Lu
2008-08-03 2:59 ` [PATCH 01/25] x86: 64bit support more than 256 irq v2 Yinghai Lu
2008-08-03 2:59 ` [PATCH 02/25] x86: remove irq_vectors_limits Yinghai Lu
2008-08-03 2:59 ` [PATCH 03/25] add dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 04/25] add per_cpu_dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 05/25] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-03 2:59 ` [PATCH 06/25] x86: enable dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 07/25] introduce nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 08/25] x86: using nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 09/25] drivers/char to use nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 10/25] drivers/net " Yinghai Lu
2008-08-03 2:59 ` [PATCH 11/25] drivers intr remapping " Yinghai Lu
2008-08-03 2:59 ` [PATCH 12/25] drivers/pcmcia " Yinghai Lu
2008-08-03 2:59 ` [PATCH 13/25] drivers/rtc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 14/25] drivers/scsi " Yinghai Lu
2008-08-03 2:59 ` [PATCH 15/25] drivers/serial " Yinghai Lu
2008-08-03 2:59 ` [PATCH 16/25] drivers proc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 17/25] drivers xen events " Yinghai Lu
2008-08-03 2:59 ` [PATCH 18/25] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-03 2:59 ` [PATCH 19/25] make irq2_iommu " Yinghai Lu
2008-08-03 2:59 ` [PATCH 20/25] make irq_desc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Yinghai Lu
2008-08-03 2:59 ` [PATCH 22/25] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-03 2:59 ` Yinghai Lu [this message]
2008-08-03 2:59 ` [PATCH 24/25] x86: get mp_irqs from madt Yinghai Lu
2008-08-03 2:59 ` [PATCH 25/25] x86: remove nr_irq_vectors Yinghai Lu
2008-08-03 13:03 ` [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Alan Cox
2008-08-03 15:14 ` Alan Cox
2008-08-03 19:57 ` Eric W. Biederman
2008-08-04 14:17 ` Alan Cox
2008-08-04 18:13 ` Yinghai Lu
2008-08-04 18:51 ` Eric W. Biederman
2008-08-06 13:09 ` [PATCH] serial: Remove NR_IRQS usage Alan Cox
2008-08-06 16:10 ` Eric W. Biederman
2008-08-03 13:02 ` [PATCH 15/25] drivers/serial to use nr_irqs Alan Cox
2008-08-03 17:43 ` Yinghai Lu
2008-08-03 4:16 ` [PATCH 05/25] x86: alloc dyn_array all alltogether Johannes Weiner
2008-08-03 4:03 ` [PATCH 03/25] add dyn_array support Johannes Weiner
2008-08-03 4:21 ` Yinghai Lu
2008-08-03 4:55 ` Johannes Weiner
2008-08-03 5:04 ` Yinghai Lu
2008-08-03 5:31 ` Johannes Weiner
2008-08-03 5:39 ` Yinghai Lu
2008-08-03 5:40 ` Yinghai Lu
2008-08-03 5:47 ` Johannes Weiner
2008-08-03 5:48 ` Yinghai Lu
2008-08-03 5:51 ` [PATCH 00/25] dyn_array and nr_irqs support v3 Eric W. Biederman
2008-08-03 6:04 ` Yinghai Lu
2008-08-03 6:39 ` Eric W. Biederman
2008-08-03 8:25 ` Yinghai Lu
2008-08-03 9:15 ` Eric W. Biederman
2008-08-03 17:54 ` Yinghai Lu
2008-08-03 19:20 ` Yinghai Lu
2008-08-04 1:59 ` Yinghai Lu
2008-08-04 14:31 ` Mike Travis
2008-08-05 23:01 ` H. Peter Anvin
2008-08-05 23:15 ` Yinghai Lu
2008-08-05 23:26 ` H. Peter Anvin
2008-08-05 23:53 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217732365-16595-24-git-send-email-yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox