From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: David Miller <davem@davemloft.net>,
akpm@linux-foundation.org, mingo@redhat.com, tglx@linutronix.de,
hpa@zytor.com, rth@twiddle.net, paulus@samba.org,
fujita.tomonori@lab.ntt.co.jp, muli@il.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] sparc64: use iommu_num_pages function in IOMMU code
Date: Tue, 05 Aug 2008 18:23:29 +1000 [thread overview]
Message-ID: <1217924609.24157.170.camel@pasglop> (raw)
In-Reply-To: <20080805074935.GA32012@amd.com>
> I didn't want to change multiple architectures with a single patch so I
> splitted it up. The whole renaming in the beginning is to make the patch
> series bisectable. But if its no problem to change multiple
> architectures with one patch I will those changes in a single patch next
> time.
I wouldn't say there's a strict rule. It's a balance to find between
the complexity of the patch, the risk of breaking archs, etc...
In your case, the added churn of going through a temporary renamed
helper represents more, imho, than the risk of breakage of what is
a fairly trivial patch in the first place. Also, it only affects a few
archs. So it's simpler or everybody to deal with a single patch even if
that means it -might- need a rev or two in case it does indeed break
something...
Ben.
next prev parent reply other threads:[~2008-08-05 8:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 16:04 [PATCH 0/10] introduce generic iommu_num_pages function Joerg Roedel
2008-08-04 16:04 ` [PATCH 01/10] x86: rename iommu_num_pages function to iommu_nr_pages Joerg Roedel
2008-08-04 16:04 ` [PATCH 02/10] sparc64: " Joerg Roedel
2008-08-04 21:27 ` David Miller
2008-08-04 16:04 ` [PATCH 03/10] powerpc: " Joerg Roedel
2008-08-04 16:04 ` [PATCH 04/10] introduce generic iommu_num_pages function Joerg Roedel
2008-08-04 16:04 ` [PATCH 05/10] x86: convert GART driver to " Joerg Roedel
2008-08-04 16:04 ` [PATCH 06/10] x86, AMD IOMMU: convert " Joerg Roedel
2008-08-04 16:04 ` [PATCH 07/10] x86: convert Calgary IOMMU " Joerg Roedel
2008-08-04 16:09 ` Muli Ben-Yehuda
2008-08-04 16:04 ` [PATCH 08/10] powerpc: use iommu_num_pages function in IOMMU code Joerg Roedel
2008-08-04 16:04 ` [PATCH 09/10] alpha: " Joerg Roedel
2008-08-04 16:04 ` [PATCH 10/10] sparc64: " Joerg Roedel
2008-08-04 21:28 ` David Miller
2008-08-05 1:09 ` Benjamin Herrenschmidt
2008-08-05 2:04 ` FUJITA Tomonori
2008-08-05 7:49 ` Joerg Roedel
2008-08-05 8:23 ` Benjamin Herrenschmidt [this message]
2008-08-05 1:08 ` [PATCH 0/10] introduce generic iommu_num_pages function Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217924609.24157.170.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=muli@il.ibm.com \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox