From: Austin Zhang <austin_zhang@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API.
Date: Tue, 05 Aug 2008 05:59:11 -0400 [thread overview]
Message-ID: <1217930351.1613.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20080804141916.GC11415@gondor.apana.org.au>
On Mon, 2008-08-04 at 22:19 +0800, Herbert Xu wrote:
> On Mon, Aug 04, 2008 at 05:35:07AM -0400, Austin Zhang wrote:
> >
> > +config CRYPTO_CRC32C_INTEL
> > + tristate "CRC32c INTEL hardware acceleration"
> > + select CRYPTO_HASH
>
> You need some sort of a dependency here. See what the other
> assembly algorithms do it.
>
> Cheers,
How about:
+config CRYPTO_CRC32C_INTEL
+ tristate "CRC32c INTEL hardware acceleration"
+ depends on X86
+ select CRYPTO_ALGAPI
+ help
+ In Intel processor with SSE4.2 supported, the processor will
......
It should only depend on X86.
next prev parent reply other threads:[~2008-08-05 10:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 9:35 [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API Austin Zhang
2008-08-04 10:12 ` David Woodhouse
2008-08-04 10:25 ` Sebastian Siewior
2008-08-04 10:27 ` David Woodhouse
2008-08-04 10:48 ` Herbert Xu
2008-08-04 10:35 ` Austin Zhang
2008-08-04 10:45 ` David Woodhouse
2008-08-04 10:58 ` Austin Zhang
2008-08-04 11:25 ` David Woodhouse
2008-08-04 13:45 ` Chris Mason
2008-08-04 15:42 ` Herbert Xu
2008-08-04 16:14 ` Chris Mason
2008-08-04 16:45 ` Herbert Xu
2008-08-04 17:06 ` Arjan van de Ven
2008-08-04 17:10 ` Herbert Xu
2008-08-04 17:13 ` Herbert Xu
2008-08-05 11:10 ` Helge Hafting
2008-08-05 14:04 ` Herbert Xu
2008-08-04 18:02 ` Benoit Boissinot
2008-08-05 2:08 ` Herbert Xu
2008-08-04 14:04 ` Herbert Xu
2008-08-04 14:20 ` Arjan van de Ven
2008-08-04 14:49 ` David Woodhouse
2008-08-04 14:54 ` Herbert Xu
2008-08-04 15:12 ` Herbert Xu
2008-08-04 14:13 ` David Woodhouse
2008-08-04 14:17 ` Herbert Xu
2008-08-05 9:51 ` Austin Zhang
2008-08-04 14:18 ` Herbert Xu
2008-08-04 14:19 ` Herbert Xu
2008-08-05 9:59 ` Austin Zhang [this message]
2008-08-05 10:44 ` Herbert Xu
2008-08-04 17:27 ` Randy Dunlap
2008-08-05 10:12 ` Austin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217930351.1613.4.camel@localhost.localdomain \
--to=austin_zhang@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox