Re: [PATCH 00/33] dyn_array and nr_irqs support v4

Eric W. Biederman
2008-08-07T01:13:30Z

Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

> A lot of these are range checks so could be replaced by a single
> valid_irq(irq) test.

Yes. My first impression was that with NR_IRQS dead valid_irq could
easily become. #define valid_irq(irq) ((irq) != 0) However thinking
just a little more since ultimately we will know which irqs have
something hooked up to them we might actually be able to say something
more interesting. So I guess actually having a valid irq function
makes sense. Instead of doing the idiomatic if (irq) logic inline.

Eric