Re: [PATCH 00/33] dyn_array and nr_irqs support v4

Alan Cox
2008-08-07T00:05:35Z

On Wed, 06 Aug 2008 13:35:55 -0700
ebiederm@xmission.com (Eric W. Biederman) wrote:

> "Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>
> >> My suggestion for a non-breaking path:
> >> - Kill NR_IRQS in then generic code.
> >> With Alan's serial patch and my kstat patch it looks like we have
> >> the worst of that.
> >
> > will use Alan's patch.at first.
> > already reused your patch about kstat. and move kstat_irqs to irq_desc.
>
> Part of what I am thinking is that there should never be a patch
> that does s/NR_IRQS/nr_irqs/ that is just pointless noise.
>
> Either we need a new abstraction like for_each_irq or to update the
> code to the current best practices.
>
> Which means the patches should be uncontroversial and mergeble on their
> own with no weird dependencies.

A lot of these are range checks so could be replaced by a single
valid_irq(irq) test.

Alan