Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API -V3.

[Austin Zhang <austin_zhang@linux.intel.com>]

Paval,

Thanks for your comments. 

On Wed, 2008-08-06 at 11:42 +0200, Pavel Machek wrote:
> Copyright / GPL?
Yes, as : +MODULE_LICENSE("GPL");

> > +#ifdef CONFIG_X86_64
> > +#define REX_PRE "0x48, "
> > +#define SCALE_F 8
> > +#else
> > +#define REX_PRE
> > +#define SCALE_F 4
> > +#endif
> 
> Ouch...
Any good suggestion will be appreciated. 

> > +static u32 crc32c_intel_le_hw_byte(u32 crc, unsigned char const *data, size_t length)
> > +{
> > +	while (length--) {
> > +		__asm__ __volatile__(
> 
> Are all the underscores neccessary?
What's big impact if keep those underscores? Just keep ANSI C  style.


> 
> > +		return -1;
> 
> That's supposed to be errno, right?
Are you suggest "ENODEV"? It's a feature from the device but the device is exact here. 
And for the crc32c algorithm, there would be possible that several
algorithms registered themselves in crypto and user will don't care
which implementation will server him even the hardware accelerated
implementation don't exist in this processor.