From: Austin Zhang <austin_zhang@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Pavel Machek <pavel@suse.cz>,
bunk@kernel.org, dwmw2@infradead.org, davem@davemloft.net,
randy.dunlap@oracle.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API -V3.
Date: Wed, 06 Aug 2008 07:20:14 -0400 [thread overview]
Message-ID: <1218021614.29030.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20080806111724.GA32129@gondor.apana.org.au>
On Wed, 2008-08-06 at 19:17 +0800, Herbert Xu wrote:
> On Wed, Aug 06, 2008 at 07:05:27AM -0400, Austin Zhang wrote:
> >
> > > > + return -1;
> > >
> > > That's supposed to be errno, right?
> > Are you suggest "ENODEV"? It's a feature from the device but the device is exact here.
>
> Yes I think this should be ENODEV to be consistent with the
> existing drivers such as padlock-aes.c.
>
> I'll make that change in cryptodev.
>
> Thanks,
Thank you, Pavel and Herbert.
next prev parent reply other threads:[~2008-08-06 11:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 5:23 [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API -V3 Austin Zhang
2008-08-06 9:42 ` Pavel Machek
2008-08-06 11:03 ` Herbert Xu
2008-08-06 11:05 ` Austin Zhang
2008-08-06 11:17 ` Herbert Xu
2008-08-06 11:20 ` Austin Zhang [this message]
2008-08-06 11:22 ` Herbert Xu
2008-08-06 12:14 ` Pavel Machek
2008-08-07 2:00 ` Herbert Xu
2008-08-06 10:09 ` Herbert Xu
2008-08-08 3:38 ` Ulrich Drepper
2008-08-08 13:35 ` Herbert Xu
2008-08-11 16:10 ` Pavel Machek
2008-08-13 1:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218021614.29030.19.camel@localhost.localdomain \
--to=austin_zhang@linux.intel.com \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox