From: Jaswinder Singh <jaswinder@infradead.org>
To: Gene Heskett <gene.heskett@gmail.com>
Cc: martin@valinux.com, gareth@valinux.com, airlied@linux.ie,
dri-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] radeon_cp: use request_firmware
Date: Thu, 07 Aug 2008 22:34:08 +0530 [thread overview]
Message-ID: <1218128648.14483.13.camel@jaswinder.satnam> (raw)
In-Reply-To: <200808070624.12214.gene.heskett@gmail.com>
Hello Gene,
On Thu, 2008-08-07 at 06:24 -0400, Gene Heskett wrote:
> When applied to 2.6.27-rc2, firmware/Makefile was rejected, so I manually added
> the blob list to that Makefile in what looked to be the correct place. And added a
> "make firmware_install" to my kernel builder script.
>
> Unforch:
> MK_FW firmware/R100_cp.bin.ihex.gen.S
> make[1]: *** No rule to make target `firmware/R100_cp.bin.ihex', needed by `firmware/R100_cp.bin.ihex.gen.o'. Stop.
> make[1]: *** Waiting for unfinished jobs....
> make: *** [firmware] Error 2
>
It seems your firmware/Makefile is not good.
it should look like this :-
fw-shipped-$(CONFIG_DRM_RADEON) += radeon/R100_cp.bin radeon/R200_cp.bin \
radeon/R300_cp.bin radeon/R420_cp.bin \
radeon/RS600_cp.bin radeon/RS690_cp.bin \
radeon/R520_cp.bin
I think you forget to write radeon before R100_cp.bin
And you can collect my updated patch from :
http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git
Thank you,
Jaswinder Singh.
next prev parent reply other threads:[~2008-08-07 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 7:51 [PATCH] radeon_cp: use request_firmware Jaswinder Singh
2008-08-07 10:24 ` Gene Heskett
2008-08-07 17:04 ` Jaswinder Singh [this message]
2008-12-19 20:23 ` Jaswinder Singh
2008-12-21 20:58 ` Dave Airlie
2008-12-22 10:39 ` Julien Cristau
2008-12-23 14:53 ` Ben Hutchings
2008-12-30 3:02 ` Jaswinder Singh Rajput
2008-12-30 4:04 ` [PATCH] radeon: Use request_firmware() to load CP microcode Ben Hutchings
2008-12-22 11:27 ` [PATCH] radeon_cp: use request_firmware Jaswinder Singh
-- strict thread matches above, loose matches on Subject: below --
2009-04-13 16:27 Jaswinder Singh Rajput
2009-04-13 18:26 ` Ben Hutchings
2009-04-14 4:54 ` Jaswinder Singh Rajput
2009-04-14 14:26 ` Ben Hutchings
2009-04-14 14:50 ` Krzysztof Halasa
2009-04-14 21:06 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218128648.14483.13.camel@jaswinder.satnam \
--to=jaswinder@infradead.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=gareth@valinux.com \
--cc=gene.heskett@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@valinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox