Re: [PATCH]: radeonfb: Fix copyarea for R300 and later.

Geert Uytterhoeven
2008-08-07T12:22:56Z

Hi Ben,

On Thu, 7 Aug 2008, Benjamin Herrenschmidt wrote:
> > + /* Ensure the dst cache is flushed and the engine idle before
> > + * issuing the operation.
> > + *
> > + * This works around engine lockups on some cards
> > + */
> > + OUTREG(DSTCACHE_CTLSTAT, RB2D_DC_FLUSH_ALL);
> > + OUTREG(WAIT_UNTIL, (WAIT_2D_IDLECLEAN | WAIT_DMA_GUI_IDLE));
> > +
> > radeon_fifo_wait(2);
>
> Typo in the patch, missing radeon_fifo_wait before the cache flush.
>
> Fixed version on it's way, sorry.

Can we please get a CC: linux-fbdev-devel on the fixed version?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds