From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: fix shadowed variable warning
Date: Sat, 09 Aug 2008 15:57:00 -0700 [thread overview]
Message-ID: <1218322620.24441.8.camel@brick> (raw)
arch/x86/kernel/pvclock.c:102:6: warning: symbol 'tsc_khz' shadows an earlier one
include/asm/tsc.h:18:21: originally declared here
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Introduced between next-20080729 and next-20080808
arch/x86/kernel/pvclock.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c
index 1c54b5f..4f9c55f 100644
--- a/arch/x86/kernel/pvclock.c
+++ b/arch/x86/kernel/pvclock.c
@@ -99,14 +99,14 @@ static unsigned pvclock_get_time_values(struct pvclock_shadow_time *dst,
unsigned long pvclock_tsc_khz(struct pvclock_vcpu_time_info *src)
{
- u64 tsc_khz = 1000000ULL << 32;
+ u64 pv_tsc_khz = 1000000ULL << 32;
- do_div(tsc_khz, src->tsc_to_system_mul);
+ do_div(pv_tsc_khz, src->tsc_to_system_mul);
if (src->tsc_shift < 0)
- tsc_khz <<= -src->tsc_shift;
+ pv_tsc_khz <<= -src->tsc_shift;
else
- tsc_khz >>= src->tsc_shift;
- return tsc_khz;
+ pv_tsc_khz >>= src->tsc_shift;
+ return pv_tsc_khz;
}
cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src)
--
1.6.0.rc1.278.g9c632
next reply other threads:[~2008-08-09 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 22:57 Harvey Harrison [this message]
2008-08-11 11:07 ` [PATCH] x86: fix shadowed variable warning Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218322620.24441.8.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox