public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Mike Travis <travis@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH 30/43] x86: put timer_rand_state pointer into irq_desc
Date: Sun, 10 Aug 2008 00:36:19 -0700	[thread overview]
Message-ID: <1218353792-3355-31-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1218353792-3355-30-git-send-email-yhlu.kernel@gmail.com>

so could remove timer_rand_state pointer array
v2: keep the old way to support arch not support irq_desc

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
 drivers/char/random.c |   66 +++++++++++++++++++++++++++++++++++++++++++++---
 include/linux/irq.h   |    2 +
 2 files changed, 63 insertions(+), 5 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 872669e..9af9bf7 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -557,7 +557,7 @@ struct timer_rand_state {
 	unsigned dont_count_entropy:1;
 };
 
-static struct timer_rand_state input_timer_state;
+#ifndef CONFIG_HAVE_SPARSE_IRQ
 
 #ifdef CONFIG_HAVE_DYN_ARRAY
 static struct timer_rand_state **irq_timer_state;
@@ -566,6 +566,51 @@ DEFINE_DYN_ARRAY(irq_timer_state, sizeof(struct timer_rand_state *), nr_irqs, PA
 static struct timer_rand_state *irq_timer_state[NR_IRQS];
 #endif
 
+static struct timer_rand_state *get_timer_rand_state(unsigned int irq)
+{
+	if (irq >= nr_irqs)
+		return NULL;
+
+	return irq_timer_state[irq];
+}
+
+static void set_timer_rand_state(unsigned int irq, struct timer_rand_state *state)
+{
+	if (irq >= nr_irqs)
+		return;
+
+	irq_timer_state[irq] = state;
+}
+
+#else
+
+static struct timer_rand_state *get_timer_rand_state(unsigned int irq)
+{
+	struct irq_desc *desc;
+
+	desc = irq_desc(irq);
+
+	if (!desc)
+		return NULL;
+
+	return desc->timer_rand_state;
+}
+
+static void set_timer_rand_state(unsigned int irq, struct timer_rand_state *state)
+{
+	struct irq_desc *desc;
+
+	desc = irq_desc(irq);
+
+	if (!desc)
+		return;
+
+	desc->timer_rand_state = state;
+}
+#endif
+
+static struct timer_rand_state input_timer_state;
+
 /*
  * This function adds entropy to the entropy "pool" by using timing
  * delays.  It uses the timer_rand_state structure to make an estimate
@@ -653,11 +698,15 @@ EXPORT_SYMBOL_GPL(add_input_randomness);
 
 void add_interrupt_randomness(int irq)
 {
-	if (irq >= nr_irqs || irq_timer_state[irq] == NULL)
+	struct timer_rand_state *state;
+
+	state = get_timer_rand_state(irq);
+
+	if (state == NULL)
 		return;
 
 	DEBUG_ENT("irq event %d\n", irq);
-	add_timer_randomness(irq_timer_state[irq], 0x100 + irq);
+	add_timer_randomness(state, 0x100 + irq);
 }
 
 #ifdef CONFIG_BLOCK
@@ -917,7 +966,14 @@ void rand_initialize_irq(int irq)
 {
 	struct timer_rand_state *state;
 
-	if (irq >= nr_irqs || irq_timer_state[irq])
+#ifndef CONFIG_HAVE_SPARSE_IRQ
+	if (irq >= nr_irqs)
+		return;
+#endif
+
+	state = get_timer_rand_state(irq);
+
+	if (state)
 		return;
 
 	/*
@@ -926,7 +982,7 @@ void rand_initialize_irq(int irq)
 	 */
 	state = kzalloc(sizeof(struct timer_rand_state), GFP_KERNEL);
 	if (state)
-		irq_timer_state[irq] = state;
+		set_timer_rand_state(irq, state);
 }
 
 #ifdef CONFIG_BLOCK
diff --git a/include/linux/irq.h b/include/linux/irq.h
index d447906..74f6bce 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -127,6 +127,7 @@ struct irq_chip {
 	const char	*typename;
 };
 
+struct timer_rand_state;
 /**
  * struct irq_desc - interrupt descriptor
  *
@@ -155,6 +156,7 @@ struct irq_desc {
 	unsigned int		irq;
 #ifdef CONFIG_HAVE_SPARSE_IRQ
 	struct irq_desc		*next;
+	struct timer_rand_state *timer_rand_state;
 #endif
 	irq_flow_handler_t	handle_irq;
 	struct irq_chip		*chip;
-- 
1.5.4.5


  reply	other threads:[~2008-08-10  7:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10  7:35 [PATCH 00/43] dyn_array/nr_irqs/sparse_irq support v7 Yinghai Lu
2008-08-10  7:35 ` [PATCH 01/43] x86_64: Restore the proper NR_IRQS define so larger systems work Yinghai Lu
2008-08-10  7:35   ` [PATCH 02/43] 8250: Remove NR_IRQ usage Yinghai Lu
2008-08-10  7:35     ` [PATCH 03/43] x86: add after_bootmem for 32bit Yinghai Lu
2008-08-10  7:35       ` [PATCH 04/43] x86: remove irq_vectors_limits Yinghai Lu
2008-08-10  7:35         ` [PATCH 05/43] add dyn_array support Yinghai Lu
2008-08-10  7:35           ` [PATCH 06/43] add per_cpu_dyn_array support Yinghai Lu
2008-08-10  7:35             ` [PATCH 07/43] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-10  7:35               ` [PATCH 08/43] x86: enable dyn_array support Yinghai Lu
2008-08-10  7:35                 ` [PATCH 09/43] introduce nr_irqs Yinghai Lu
2008-08-10  7:35                   ` [PATCH 10/43] x86: using nr_irqs Yinghai Lu
2008-08-10  7:36                     ` [PATCH 11/43] drivers/char to use nr_irqs Yinghai Lu
2008-08-10  7:36                       ` [PATCH 12/43] drivers/net " Yinghai Lu
2008-08-10  7:36                         ` [PATCH 13/43] drivers intr remapping " Yinghai Lu
2008-08-10  7:36                           ` [PATCH 14/43] drivers/pcmcia " Yinghai Lu
2008-08-10  7:36                             ` [PATCH 15/43] drivers/rtc " Yinghai Lu
2008-08-10  7:36                               ` [PATCH 16/43] drivers/scsi " Yinghai Lu
2008-08-10  7:36                                 ` [PATCH 17/43] drivers/serial " Yinghai Lu
2008-08-10  7:36                                   ` [PATCH 18/43] drivers proc " Yinghai Lu
2008-08-10  7:36                                     ` [PATCH 19/43] drivers xen events " Yinghai Lu
2008-08-10  7:36                                       ` [PATCH 20/43] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-10  7:36                                         ` [PATCH 21/43] make irq2_iommu " Yinghai Lu
2008-08-10  7:36                                           ` [PATCH 22/43] make irq_desc " Yinghai Lu
2008-08-10  7:36                                             ` [PATCH 23/43] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-10  7:36                                               ` [PATCH 24/43] x86: use dyn_array in io_apic_xx.c Yinghai Lu
2008-08-10  7:36                                                 ` [PATCH 25/43] x86: get mp_irqs from madt Yinghai Lu
2008-08-10  7:36                                                   ` [PATCH 26/43] x86: remove nr_irq_vectors Yinghai Lu
2008-08-10  7:36                                                     ` [PATCH 27/43] x86_64: use irq_desc() together with dyn_array Yinghai Lu
2008-08-10  7:36                                                       ` [PATCH 28/43] x86: add irq_cfg in io_apic_64.c Yinghai Lu
2008-08-10  7:36                                                         ` [PATCH 29/43] x86: put irq_2_pin pointer into irq_cfg Yinghai Lu
2008-08-10  7:36                                                           ` Yinghai Lu [this message]
2008-08-10  7:36                                                             ` [PATCH 31/43] x86: move kstat_irqs from kstat to irq_desc Yinghai Lu
2008-08-10  7:36                                                               ` [PATCH 32/43] add irq_desc_without_new Yinghai Lu
2008-08-10  7:36                                                                 ` [PATCH 33/43] replace loop with nr_irqs with for_each_irq_desc Yinghai Lu
2008-08-10  7:36                                                                   ` [PATCH 34/43] replace loop with nr_irqs for proc/stat Yinghai Lu
2008-08-10  7:36                                                                     ` [PATCH 35/43] replace loop with nr_irqs with for_each_irq_icfg Yinghai Lu
2008-08-10  7:36                                                                       ` [PATCH 36/43] remove >= nr_irqs checking with config_have_sparse_irq Yinghai Lu
2008-08-10  7:36                                                                         ` [PATCH 37/43] x86_64: add irq_desc in function in paramater Yinghai Lu
2008-08-10  7:36                                                                           ` [PATCH 38/43] x86: check with without_new in show_interrupts Yinghai Lu
2008-08-10  7:36                                                                             ` [PATCH 39/43] x86_64: rename irq_desc/irq_desc_with_new Yinghai Lu
2008-08-10  7:36                                                                               ` [PATCH 40/43] seperate irq_descX with irq_descX_free Yinghai Lu
2008-08-10  7:36                                                                                 ` [PATCH 41/43] x86_64: sperate irq_cfgx with irq_cfgx_free Yinghai Lu
2008-08-10  7:36                                                                                   ` [PATCH 42/43] x86_64: make /proc/interrupts works with dyn irq_desc Yinghai Lu
2008-08-10  7:36                                                                                     ` [PATCH 43/43] x86: put irq_2_iommu pointer into irq_desc Yinghai Lu
2008-08-10  9:21 ` [PATCH 00/43] dyn_array/nr_irqs/sparse_irq support v7 Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218353792-3355-31-git-send-email-yhlu.kernel@gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox