From: Huang Ying <ying.huang@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Vivek Goyal <vgoyal@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Machek <pavel@ucw.cz>,
nigel@nigel.suspend2.net, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH -v2 7/8] kexec jump: ftrace_enabled_save/restore
Date: Mon, 11 Aug 2008 09:22:21 +0800 [thread overview]
Message-ID: <1218417741.30464.23.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0808081026240.22796@gandalf.stny.rr.com>
Hi, Steven,
On Fri, 2008-08-08 at 10:30 -0400, Steven Rostedt wrote:
[...]
> The only problem with this approach is what happens if the user changes
> the enabled in between these two calls. This would make ftrace
> inconsistent.
>
> I have a patch from the -rt tree that handles what you want. It is
> attached below. Not sure how well it will apply to mainline.
>
> I really need to go through the rt patch set and start submitting a bunch
> of clean-up/fixes to mainline. We've been meaning to do it, just have been
> distracted :-(
Your version is better in general sense. Thank you very much!
But in this specific situation of kexec/kjump. The execution environment
is that other CPUs are disabled, local irq is disabled, and it is not
permitted to switch to other process. But it is safe and sufficient to
use non-locked version here.
So to satisfy both demands, I think it is better to provide both
version, locked and non-locked. What do you think about that?
Best Regards,
Huang Ying
next prev parent reply other threads:[~2008-08-11 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 6:52 [PATCH -v2 7/8] kexec jump: ftrace_enabled_save/restore Huang Ying
2008-08-08 14:17 ` Vivek Goyal
2008-08-08 14:30 ` Steven Rostedt
2008-08-11 1:22 ` Huang Ying [this message]
2008-08-11 12:29 ` Steven Rostedt
2008-08-11 13:51 ` Vivek Goyal
2008-08-12 1:22 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218417741.30464.23.camel@caritas-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox