From: Huang Ying <ying.huang@intel.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Machek <pavel@ucw.cz>,
nigel@nigel.suspend2.net, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>,
mingo@elte.hu, Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Kexec Mailing List <kexec@lists.infradead.org>
Subject: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()
Date: Wed, 13 Aug 2008 17:12:40 +0800 [thread overview]
Message-ID: <1218618760.24951.137.camel@caritas-dev.intel.com> (raw)
Fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec().
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
kernel/kexec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1433,6 +1433,7 @@ module_init(crash_save_vmcoreinfo_init)
int kernel_kexec(void)
{
int error = 0;
+ int locked;
if (xchg(&kexec_lock, 1))
return -EBUSY;
@@ -1498,7 +1499,8 @@ int kernel_kexec(void)
#endif
Unlock:
- xchg(&kexec_lock, 0);
+ locked = xchg(&kexec_lock, 0);
+ BUG_ON(!locked);
return error;
}
next reply other threads:[~2008-08-13 9:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 9:12 Huang Ying [this message]
2008-08-13 9:27 ` [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec() Andrew Morton
2008-08-13 17:01 ` Linus Torvalds
2008-08-13 17:25 ` Andrew Morton
2008-08-13 17:59 ` Ingo Molnar
2008-08-13 16:57 ` Linus Torvalds
2008-08-13 18:12 ` Eric W. Biederman
2008-08-13 18:31 ` Vivek Goyal
2008-08-13 19:44 ` Andrew Morton
2008-08-13 19:50 ` Linus Torvalds
2008-08-13 20:07 ` Andrew Morton
2008-08-13 20:13 ` Linus Torvalds
2008-08-13 20:25 ` Andrew Morton
2008-08-13 20:31 ` Linus Torvalds
2008-08-13 20:41 ` Andrew Morton
2008-08-13 21:21 ` Vivek Goyal
2008-08-13 22:17 ` Linus Torvalds
2008-08-13 20:15 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218618760.24951.137.camel@caritas-dev.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox