Re: [PATCH 1/3] relay: Fix 4 off-by-one errors occuring when writing to a CPU buffer.

[Tom Zanussi <tzanussi@gmail.com>]

Hi,

On Thu, 2008-08-14 at 19:35 +0300, Eduard - Gabriel Munteanu wrote:

> BTW, did the kmemtrace user app work for you? Pekka seemed to have
> issues with compiling it.
> 

Just a small problem compiling - there was no Makefile or configure, and
the README doesn't say anything about autogen.sh, though I later saw
something about it in the kernel documentation.  Anyway, autogen.sh
failed because I didn't have autoconf/automake installed; after doing
that I didn't have a problem compiling.  I did notice a couple printf
format warnings, though.

I then ran kmemtraced and ran the check and report on the output.  The
check passed but the report tool just spewed a lot of error lines with
the same caller.  I looked a little closer and realized there was
something really wrong with the reporting tool e.g. a tiny trace of
about 10k, probably fewer than 200 events (a hexdump of the data looked
ok to me), produced a report of about 800k.  Remembering the printf
format warnings, I realized it probably hadn't been run on a 32-bit
system lately, so I tried it all again on a 64-bit system, and there it
seemed to work ok, or at least the output looked reasonable, to my
untrained eye.

Tom