public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Andrew Vasquez <andrew.vasquez@qlogic.com>
Subject: Re: [PATCH] pci: change msi-x vector to 32bit
Date: Sat, 16 Aug 2008 11:13:29 -0500	[thread overview]
Message-ID: <1218903209.3940.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20080816163945.74d487e9@lxorguk.ukuu.org.uk>

On Sat, 2008-08-16 at 16:39 +0100, Alan Cox wrote:
> > Where exactly is this code in the kernel?  Most arches assume the irq is
> > an index to a compact table bounded by NR_IRQS, so something like this
> > would violate that assumption.
> 
> Yes, which is no bad thing for some platforms. There are some driver
> assumptions like that but those have also been stomped.

I'm not saying we couldn't do this, or even that we shouldn't; I'm just
asking why would we want to?

All arches currently seem to have show_interrupts() which loop over
0..NR_IRQS where the interrupt is printed as %d.  In this encoded scheme
they would show up with rather nastily large numbers that have no
visible meaning unless we switch to hex for displaying them.

What I'm really saying is that irq as the interrupt number is really the
*user's* handle for the interrupt not the machine's, so it needs to be
something the user is comfortable with.  We could overcome this
objection by encoding the number to something meaningful for the
user ... I'm just asking if there's any benefit to doing this?

James



  reply	other threads:[~2008-08-16 16:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-16  3:26 [PATCH] pci: change msi-x vector to 32bit H. Peter Anvin
2008-08-16  6:42 ` Yinghai Lu
2008-08-16 14:50   ` James Bottomley
2008-08-16 15:39     ` Alan Cox
2008-08-16 16:13       ` James Bottomley [this message]
2008-08-16 18:56         ` Yinghai Lu
2008-08-16 20:10           ` Andrew Vasquez
2008-08-16 20:25           ` James Bottomley
2008-08-16 20:34             ` Yinghai Lu
2008-08-16 20:45               ` James Bottomley
2008-08-16 22:17                 ` Yinghai Lu
2008-08-16 23:09                   ` James Bottomley
2008-08-16 23:21                     ` Yinghai Lu
2008-08-18 19:59                     ` Eric W. Biederman
2008-08-18 20:59                       ` James Bottomley
2008-08-18 21:45                         ` Eric W. Biederman
2008-08-18 22:04                           ` James Bottomley
2008-08-18 21:51                             ` Alan Cox
2008-08-18 22:13                               ` H. Peter Anvin
2008-08-18 22:27                               ` James Bottomley
2008-08-18 21:24                       ` H. Peter Anvin
2008-08-16  8:17 ` Eric W. Biederman
2008-08-16  9:00   ` Yinghai Lu
  -- strict thread matches above, loose matches on Subject: below --
2008-08-16  2:36 Yinghai Lu
2008-08-21 20:33 ` Jesse Barnes
2008-08-21 20:47   ` Eric W. Biederman
2008-08-21 23:07     ` Jesse Barnes
2008-08-22  0:11       ` Eric W. Biederman
2008-08-22  0:35         ` Jesse Barnes
2008-08-27 23:34 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218903209.3940.14.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andrew.vasquez@qlogic.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox