* [PATCH 2/2] pvrusb2: use proper byteorder interface
@ 2008-08-18 20:38 Harvey Harrison
0 siblings, 0 replies; only message in thread
From: Harvey Harrison @ 2008-08-18 20:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML, Mauro Carvalho Chehab, v4l-maintainer
___swab32 is an internal detail of the implementation.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
I really suspect this should be something like be32_to_cpu...if this code
was written on an x86.
drivers/media/video/pvrusb2/pvrusb2-hdw.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
index f051c6a..7fa903a 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
@@ -1314,8 +1314,7 @@ int pvr2_upload_firmware2(struct pvr2_hdw *hdw)
memcpy(fw_ptr, fw_entry->data + fw_done, bcnt);
/* Usbsnoop log shows that we must swap bytes... */
for (icnt = 0; icnt < bcnt/4 ; icnt++)
- ((u32 *)fw_ptr)[icnt] =
- ___swab32(((u32 *)fw_ptr)[icnt]);
+ ((u32 *)fw_ptr)[icnt] = swab32(((u32 *)fw_ptr)[icnt]);
ret |= usb_bulk_msg(hdw->usb_dev, pipe, fw_ptr,bcnt,
&actual_length, HZ);
--
1.6.0.274.g8aacc
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-18 20:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-18 20:38 [PATCH 2/2] pvrusb2: use proper byteorder interface Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox